From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com,
wangnan0@huawei.com, pi3orama@163.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events
Date: Fri, 25 Sep 2015 10:29:33 +0200 [thread overview]
Message-ID: <20150925082933.GE21290@krava.redhat.com> (raw)
In-Reply-To: <1443151279-141093-2-git-send-email-hekuang@huawei.com>
On Fri, Sep 25, 2015 at 03:21:19AM +0000, He Kuang wrote:
SNIP
> diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
> index c7b904a..f13d3cc 100644
> --- a/tools/perf/util/parse-events.h
> +++ b/tools/perf/util/parse-events.h
> @@ -119,7 +119,8 @@ int parse_events__modifier_group(struct list_head *list, char *event_mod);
> int parse_events_name(struct list_head *list, char *name);
> int parse_events_add_tracepoint(struct list_head *list, int *idx,
> char *sys, char *event,
> - struct parse_events_error *error);
> + struct parse_events_error *error,
> + struct list_head *head_config);
> int parse_events_add_numeric(struct parse_events_evlist *data,
> struct list_head *list,
> u32 type, u64 config,
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 8bcc458..6b15a80 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -67,6 +67,7 @@ static inc_group_count(struct list_head *list,
> %type <head> event_legacy_cache
> %type <head> event_legacy_mem
> %type <head> event_legacy_tracepoint
> +%type <str_group> __event_legacy_tracepoint
> %type <head> event_legacy_numeric
> %type <head> event_legacy_raw
> %type <head> event_def
> @@ -84,6 +85,10 @@ static inc_group_count(struct list_head *list,
> u64 num;
> struct list_head *head;
> struct parse_events_term *term;
> + struct str_group{
> + char *name1;
> + char *name2;
> + } str_group;
perhaps tracepoint_name would be more suitable?
with 'struct tracepoint_name' instead of str_group
thanks,
jirka
next prev parent reply other threads:[~2015-09-25 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 3:21 [PATCH 1/2] perf tools: Prompt error message for wrong terms of hw/sw events He Kuang
2015-09-25 3:21 ` [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events He Kuang
2015-09-25 8:29 ` Jiri Olsa [this message]
2015-09-25 8:31 ` Jiri Olsa
2015-09-25 8:15 ` [PATCH 1/2] perf tools: Prompt error message for wrong terms of hw/sw events Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925082933.GE21290@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox