From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755586AbbIYI3n (ORCPT ); Fri, 25 Sep 2015 04:29:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41614 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755272AbbIYI3k (ORCPT ); Fri, 25 Sep 2015 04:29:40 -0400 Date: Fri, 25 Sep 2015 10:29:33 +0200 From: Jiri Olsa To: He Kuang Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com, wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events Message-ID: <20150925082933.GE21290@krava.redhat.com> References: <1443151279-141093-1-git-send-email-hekuang@huawei.com> <1443151279-141093-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443151279-141093-2-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 03:21:19AM +0000, He Kuang wrote: SNIP > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h > index c7b904a..f13d3cc 100644 > --- a/tools/perf/util/parse-events.h > +++ b/tools/perf/util/parse-events.h > @@ -119,7 +119,8 @@ int parse_events__modifier_group(struct list_head *list, char *event_mod); > int parse_events_name(struct list_head *list, char *name); > int parse_events_add_tracepoint(struct list_head *list, int *idx, > char *sys, char *event, > - struct parse_events_error *error); > + struct parse_events_error *error, > + struct list_head *head_config); > int parse_events_add_numeric(struct parse_events_evlist *data, > struct list_head *list, > u32 type, u64 config, > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index 8bcc458..6b15a80 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -67,6 +67,7 @@ static inc_group_count(struct list_head *list, > %type event_legacy_cache > %type event_legacy_mem > %type event_legacy_tracepoint > +%type __event_legacy_tracepoint > %type event_legacy_numeric > %type event_legacy_raw > %type event_def > @@ -84,6 +85,10 @@ static inc_group_count(struct list_head *list, > u64 num; > struct list_head *head; > struct parse_events_term *term; > + struct str_group{ > + char *name1; > + char *name2; > + } str_group; perhaps tracepoint_name would be more suitable? with 'struct tracepoint_name' instead of str_group thanks, jirka