public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
	jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com,
	wangnan0@huawei.com, pi3orama@163.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events
Date: Fri, 25 Sep 2015 10:31:09 +0200	[thread overview]
Message-ID: <20150925083109.GF21290@krava.redhat.com> (raw)
In-Reply-To: <1443151279-141093-2-git-send-email-hekuang@huawei.com>

On Fri, Sep 25, 2015 at 03:21:19AM +0000, He Kuang wrote:

SNIP

>  }
>  
> +__event_legacy_tracepoint:
> +PE_NAME '-' PE_NAME ':' PE_NAME
> +{
> +	char sys_name[128];
> +	struct str_group group;
> +
> +	snprintf(&sys_name, 128, "%s-%s", $1, $3);
> +	group.name1 = &sys_name;
> +	group.name2 = $5;
> +
> +	$$ = group;
> +}
> +|
> +PE_NAME ':' PE_NAME
> +{
> +	struct str_group group = {$1, $3};
> +	$$ = group;
> +}
> +
>  event_legacy_numeric:
>  PE_VALUE ':' PE_VALUE
>  {
> -- 
> 1.8.5.2
> 

please split this into adding the tracepoint terms parsing support
and the new tracepoint terms config logic

thanks,
jirka

  parent reply	other threads:[~2015-09-25  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25  3:21 [PATCH 1/2] perf tools: Prompt error message for wrong terms of hw/sw events He Kuang
2015-09-25  3:21 ` [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events He Kuang
2015-09-25  8:29   ` Jiri Olsa
2015-09-25  8:31   ` Jiri Olsa [this message]
2015-09-25  8:15 ` [PATCH 1/2] perf tools: Prompt error message for wrong terms of hw/sw events Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150925083109.GF21290@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox