From: Peter Chen <peter.chen@freescale.com>
To: Felipe Tonello <eu@felipetonello.com>
Cc: USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
"Andrzej Pietrasiewicz" <andrzej.p@samsung.com>
Subject: Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support
Date: Fri, 25 Sep 2015 17:01:16 +0800 [thread overview]
Message-ID: <20150925090114.GA19496@shlinux2> (raw)
In-Reply-To: <CAGrhNMx-ZODd4tx29uve5Tc9P11U4FEnb7jW6OU3u_SSCrRpvg@mail.gmail.com>
On Fri, Sep 25, 2015 at 09:26:21AM +0100, Felipe Tonello wrote:
> Hi Peter,
>
> On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen <peter.chen@freescale.com> wrote:
> > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote:
> >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile
> >> properly.
> >>
> >
> > Would you post the warning or error messages?
> >
> > I just tried at v4.3-rc1 (v4.2 should be same), without any problems.
>
> Actually I tested again with the latest and it doesn't break. But
> still I believe it is the right thing to do, even though it builds.
> Just good practice to make sure the ifdefs are correct on driver code.
>
We need to decrease #ifdefs as less as possible, only add it if it
really needs.
--
Best Regards,
Peter Chen
prev parent reply other threads:[~2015-09-25 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 11:56 [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Felipe F. Tonello
2015-09-24 1:17 ` Peter Chen
2015-09-25 8:26 ` Felipe Tonello
2015-09-25 9:01 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925090114.GA19496@shlinux2 \
--to=peter.chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox