From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932114AbbIYJBl (ORCPT ); Fri, 25 Sep 2015 05:01:41 -0400 Received: from mail-by2on0135.outbound.protection.outlook.com ([207.46.100.135]:35844 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755429AbbIYJBh (ORCPT ); Fri, 25 Sep 2015 05:01:37 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=freescale.com; Date: Fri, 25 Sep 2015 17:01:16 +0800 From: Peter Chen To: Felipe Tonello CC: USB list , Kernel development list , Greg Kroah-Hartman , Felipe Balbi , "Andrzej Pietrasiewicz" Subject: Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support Message-ID: <20150925090114.GA19496@shlinux2> References: <1443009418-29032-1-git-send-email-eu@felipetonello.com> <20150924011715.GA10369@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD043;1:/oREoXD97bFPSvL5cS4aO3Kkg8mO4Y+LPb7KqBm9irnoTjWGz+fB5imZYt99Tsn2kJMvh/ZWGOtJN1WGXPnsOF8nqVT9Dx0JMlfarBfzo7iwp8hFBB8TyVu3kq/YfKOJuWqoHcn9rVr88OdCZ9m0ISGCtKlJC/5ujuS3yCo8svoSSEmVj6l6UfOCPSWwdPX7Elg+T6HzB+0gAPTRao+hJAk8UFQE0QhMC482aB5KYoIDdV1BbRB9ieA0Z5vnrhP+DjE/I2KlWYqndLrp5GJ2Q7+BOcOyPt1byW/ePNQ2UeCNY69znh9BUwmtuJLL2oLMVTOs9Hk6nlgtYjnDGN1xTSZZavoLkje94AGkLDO7dKvyMFYV7ih/aIlL7j7T8toM X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(377454003)(189002)(199003)(24454002)(77156002)(11100500001)(33716001)(83506001)(86362001)(50466002)(110136002)(5001960100002)(68736005)(85426001)(76176999)(5007970100001)(19580405001)(50986999)(19580395003)(87936001)(54356999)(62966003)(104016004)(92566002)(23726002)(46102003)(47776003)(5001830100001)(6806005)(33656002)(5001860100001)(64706001)(105606002)(97736004)(97756001)(46406003)(77096005)(189998001)(106466001)(2950100001)(81156007)(4001540100001)(4001350100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB484;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;2:zzGBNf56gXvCHan1zFR5VFxhI/m8iNYY9TiZrBSE7LfZYQm9dnjAX+RTNR0RBOuHEiFEit7LNihf3N8FAScCCB1UfC3nNXsCd4Ms8TEeVAWu2OYjIyp+SwN3hspBndmOIUkX4mT0O/8X7bpRhzq4WWioeoMTc2NKwj3RV8C+gp4=;3:PzSxnJlGPSimp/8xOhh5cB/w/JI2aL7g2rKuAaN6FT6YFinSmion4XHQ6cGEFyhN4gkNlgmO0T7zFwt9LWFBQh5uFNPZAcXYT3kH0EgpWlG0RdRHae1MBiJ5UYFnqvrhuDUCAA20RQ9cxtCNt6e9mcLOh6pfbY2690e8a+PhZgSDKf+oeFQoRxXLyHzYkPlaaWEJia3acvP61/AmMDto3Lp+c7axFZpJtAqJeZAl1Po=;25:aEtwNVFRvNu10yjY9QtR/cIXDnyBMCbq23kKpygPCCLnSM2whHRCoFexLQzY8tY6oadL8JGVNJ/SbByz1qz9cEixTLrsKbS+t/QD726NnPxGdrJOWKMBj6OZ4KVtSCO+apwQGYGnwrp5rGYY9fNbXyrJK8oLimJvxSugG8BW5KDes5/329+GGhq9+brTAKLoilB+artXtmMJY1Bu9Mqq36yXWCGggApwVwb2Ag8uBIHiMiHAQaBS1R0vApbog+sp X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB484; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;20:H46JMSStei82xW4/tRoDjZBxfZZOUgttMeWYKrjsVl5Art1kUya5o9sMUy9RVC9Mxy7S9WBu0jxKS+mex1ITa0DEElmNtITM0b9r8DG+YRvXPG0QawVcch1H9t3w2fWvt7lNu0nQKO1bS8cAEyzpkrQYgiakHnN79bS/B4Q8//PXs8tgWAEWh6FlPVEghu2NAjO45Uplz8c2JYfysCOsb6OAS/6xeVTNlgMSZee7hTaVstKFoSm3lKf0uhui6dSXMSl3c4hqBHidYN2Aee7QyknrLr48AzHfDCA3lsEooSark6rSqV5Bac3XNjuuip66nc76Yx9TESJw8ymRSwJKegGWMMQPqpZ0lV60faLJK8w=;4:N5d3GXN9ct9blH83ybaRZmn6BwitZ7ZOJTyAmXlUidf3K9/98Um8oKlDHofPZGpgpGht73Dq/0+752A4GvU9fYG0HGyZOww4gntnpeGiXIf0SAY7dA+wUKlMMDGVokj+V6VeajGIv9jcG/TOrCN7vBP6yU1jpGybf+upD3bcREt/NF+KMhuQKR3g0j2gppFy9V9CnkBVcUPKIHPATAZNftm6b16KIRQxO94BgbfV6aAvc4IS9jt7oOqLesRTk0p3njsUE/dWR3WTCwyB4TJdnuWH+m6eyBfv3/uWx4nkoIDbC8k/mP1NZ8I3IfP0UP3HQwtMClkgvHJPXM1f7DAMh10qJBKBaJNbbzaaTULvle4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BL2PR03MB484;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB484; X-Forefront-PRVS: 07106EF9B9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB484;23:Frt5YUs576NlfkneXhX5WaQtSycH1OhdI08eDkOTgj?= =?us-ascii?Q?Ntq9NVHb3MIXgCCW9X8MMl3Su82BK6pRlyc80XZL+2Yjv9+PXdhISPcR5H/u?= =?us-ascii?Q?lSGm6iUK7YGQulCqcZQNCUyZesQZmtwjj/LDs2U5M1xOLLpg3GIQGFgkcpkK?= =?us-ascii?Q?/MhyeOgiC0j8DB71oNccouaxRSlCTqnWSikGHGlwMUlLqwUqQThgHe58QoWJ?= =?us-ascii?Q?QM/PmGgsMsFUp89rCKjwsrWT/E93seCUI0yl5Hh1UyPL8elJl/dWwTeKKKYC?= =?us-ascii?Q?Ca0sJuEDoUQIFxeQKDbcz3zlv5NzTz/7hNdwPYMdX2jOiQJqYJWr/jhs+bYH?= =?us-ascii?Q?j/UPgo/GqOwX7cjoNDBBiAmU2FDVD2sMPTwKeOS5EQToH3I+1IWX6koWVpOY?= =?us-ascii?Q?/fOPAbT1QEWrW1++0+cFnS1+ZKwcpYKjSbpUihEJ51CHTYKrg/Ty8rv8BILJ?= =?us-ascii?Q?mNwJ5OubBRaX6TLDh/jFvzvsnVPwk69BWA2RNDBGXD+lpn2qqu3ln1idgcAB?= =?us-ascii?Q?GtAJrfzw8bzpWqJD4jh1SVwAa1pwupGZyAjISRWMEW4l1f8sz3tSgk75MF7C?= =?us-ascii?Q?/aHEvBXo6T4N2Qe3ViSdnXPrX9TJt7zwN3BAEAoeDAntLWIxMuBieA7ky0rJ?= =?us-ascii?Q?YwDaWXgceUVSZEqFDhhRHOvE9N+phkg2u29JxoAvlPTgH8d4rY/u7nH6sFkt?= =?us-ascii?Q?VNwghmRKjsdW7S3AanlMZLmggZsOMR1I3jGaWcLcbMyCXxzZsm2X0V2Aauc0?= =?us-ascii?Q?HRUMqKlIBC7WoK6evU/E09B3MQx44+pFpPjjV43SOnZAQYNquo+VMDARFiCT?= =?us-ascii?Q?k590uhL62Js84GuoLQ0vFdylu3T0BXLKWXZeiFwGOD0hyLaoLZU/+UHOCQZI?= =?us-ascii?Q?SK5CTC1bNmmPPxLOR+WjOkIBgxCySRPhECltmM3O6U0gsrGBwI+ZgPz/sPng?= =?us-ascii?Q?Ag58pU8Drm5q757X/51w0+VgZZlT+lV/uBwFnlz6kHcZ66xXrixpO0uKCpRl?= =?us-ascii?Q?FU18xClfSuif+UaBPIUFhgMJXghaJghki38F7gYl6CRCwkSMZzoulW/VpO6n?= =?us-ascii?Q?pzlVanA5jVeM854dI6Vywn7m4dmEMpIZhNPLCzj7tTNCT2UabAh4Udcfem2a?= =?us-ascii?Q?6JQ+KmiPTaIJzgVhIyQf1Cez/EBTRKBgrUcJGDXNW6AMND5fBW5MmMnKyr0W?= =?us-ascii?Q?drdO6qgopWt+Wo/L1ql/GB49hMv/Zp+6cNFQpqhiwl0aEEYpfcs7UJTodGd/?= =?us-ascii?Q?LjA/jo+6hr+FhrTzswWysaqxDWvp0pVOKQrwUM?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB484;5:gF3FPsy5OHmezUYXy6Z/9uzXkmauODYFnVN0a6e6oMS4aXCTzMWJdjw746RuLw/aXPVF6RNxFJ5YVdRebpud2063aXH1ZAJmNKU19WHHsbA1FRXDCdWyeYAcAE6OqotSAWSRzGXPP0Go4EL2GSe1Ug==;24:Ox7Z5l7wNiO50xDJdKaRPIUavHv9Ge2hlj63ERxYBeEUFRt3Uneo1ZX4rlr+znZAoJoQL8uWeOi3N8mPorGoOSKOCv/14atvojwFAyHrGvI=;20:sjwooDUwD6BDJ/NmdqsZ9MTcGkZkUATwR6hdklg223VKfuX/AE22wyfHbILdM1M3WJDTYaZszU03Hl7fQuRZVQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2015 09:01:33.6492 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 09:26:21AM +0100, Felipe Tonello wrote: > Hi Peter, > > On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen wrote: > > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: > >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile > >> properly. > >> > > > > Would you post the warning or error messages? > > > > I just tried at v4.3-rc1 (v4.2 should be same), without any problems. > > Actually I tested again with the latest and it doesn't break. But > still I believe it is the right thing to do, even though it builds. > Just good practice to make sure the ifdefs are correct on driver code. > We need to decrease #ifdefs as less as possible, only add it if it really needs. -- Best Regards, Peter Chen