From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>
Cc: linux-doc@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option
Date: Fri, 25 Sep 2015 20:28:11 +0900 [thread overview]
Message-ID: <20150925112811.4258.54494.stgit@softrs> (raw)
In-Reply-To: <20150925112803.4258.94241.stgit@softrs>
This patch introduces new boot option "noextnmi" which disables
external NMI. This option is useful for the dump capture kernel
so that an HA application or administrator wouldn't mistakenly
shoot down the kernel by NMI.
Currently, only x86 supports this option.
Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jonathan Corbet <corbet@lwn.net>
---
Documentation/kernel-parameters.txt | 4 ++++
arch/x86/kernel/apic/apic.c | 17 ++++++++++++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 22a4b68..8bcaccd 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -2379,6 +2379,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
noexec=on: enable non-executable mappings (default)
noexec=off: disable non-executable mappings
+ noextnmi [X86]
+ Mask external NMI. This option is useful for a
+ dump capture kernel to be shot down by NMI.
+
nosmap [X86]
Disable SMAP (Supervisor Mode Access Prevention)
even if it is supported by processor.
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 24e94ce..fd47128 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -82,6 +82,12 @@
static unsigned int disabled_cpu_apicid __read_mostly = BAD_APICID;
/*
+ * Don't enable external NMI via LINT1 on BSP. This is useful for
+ * the dump capture kernel.
+ */
+static bool apic_noextnmi;
+
+/*
* Map cpu index to physical APIC ID
*/
DEFINE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_cpu_to_apicid, BAD_APICID);
@@ -1161,6 +1167,8 @@ void __init init_bsp_APIC(void)
value = APIC_DM_NMI;
if (!lapic_is_integrated()) /* 82489DX */
value |= APIC_LVT_LEVEL_TRIGGER;
+ if (apic_noextnmi)
+ value |= APIC_LVT_MASKED;
apic_write(APIC_LVT1, value);
}
@@ -1380,7 +1388,7 @@ void setup_local_APIC(void)
/*
* only the BP should see the LINT1 NMI signal, obviously.
*/
- if (!cpu)
+ if (!cpu && !apic_noextnmi)
value = APIC_DM_NMI;
else
value = APIC_DM_NMI | APIC_LVT_MASKED;
@@ -2548,3 +2556,10 @@ static int __init apic_set_disabled_cpu_apicid(char *arg)
return 0;
}
early_param("disable_cpu_apicid", apic_set_disabled_cpu_apicid);
+
+static int __init apic_set_noextnmi(char *arg)
+{
+ apic_noextnmi = true;
+ return 0;
+}
+early_param("noextnmi", apic_set_noextnmi);
next prev parent reply other threads:[~2015-09-25 12:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 11:28 [V4 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec Hidehiro Kawai
2015-09-25 11:28 ` [V4 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-09-25 12:13 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-30 11:26 ` Peter Zijlstra
2015-10-01 1:02 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context Hidehiro Kawai
2015-09-30 11:50 ` Peter Zijlstra
2015-10-01 1:43 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-25 11:28 ` [V4 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-09-28 3:53 ` kbuild test robot
2015-09-28 7:08 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-30 11:53 ` Peter Zijlstra
2015-10-01 2:04 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-28 4:02 ` kbuild test robot
2015-09-28 4:46 ` 河合英宏 / KAWAI,HIDEHIRO
2015-09-25 11:28 ` Hidehiro Kawai [this message]
2015-09-30 11:55 ` [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option Peter Zijlstra
2015-10-01 2:33 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-01 6:27 ` Peter Zijlstra
2015-10-01 7:01 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-01 8:43 ` Borislav Petkov
2015-10-01 10:24 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-01 11:01 ` Borislav Petkov
2015-10-02 0:58 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-02 7:47 ` Borislav Petkov
2015-10-05 2:03 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-05 8:27 ` Borislav Petkov
2015-10-05 9:21 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-05 10:14 ` Borislav Petkov
2015-10-13 11:55 ` 河合英宏 / KAWAI,HIDEHIRO
[not found] ` <alpine.DEB.2.11.1510132210590.25029@nanos>
2015-10-14 13:54 ` Ingo Molnar
2015-10-16 1:58 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-13 20:22 ` Thomas Gleixner
2015-10-14 3:39 ` 河合英宏 / KAWAI,HIDEHIRO
[not found] ` <alpine.DEB.2.11.1510140924370.25029@nanos>
2015-10-16 2:02 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-27 8:46 ` Baoquan He
2015-10-27 9:01 ` 河合英宏 / KAWAI,HIDEHIRO
2015-10-27 9:06 ` 'Baoquan He'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925112811.4258.54494.stgit@softrs \
--to=hidehiro.kawai.ez@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).