From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756416AbbIYNmV (ORCPT ); Fri, 25 Sep 2015 09:42:21 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34129 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755924AbbIYNmT (ORCPT ); Fri, 25 Sep 2015 09:42:19 -0400 Date: Fri, 25 Sep 2015 19:12:06 +0530 From: Sudip Mukherjee To: Tomi Valkeinen Cc: Jean-Christophe Plagniol-Villard , Jonathan Corbet , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Message-ID: <20150925134206.GA4799@sudip-pc> References: <1437192539-14150-1-git-send-email-sudipm.mukherjee@gmail.com> <55E5A7BC.8060003@ti.com> <20150901135514.GB15833@sudip-pc> <55E6E45B.5030500@ti.com> <20150902124811.GA25301@sudip-pc> <5603E567.5000001@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5603E567.5000001@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote: > > On 02/09/15 15:48, Sudip Mukherjee wrote: > > > Is there a public datasheet for the HW? I could not find one in Silicon Motion website. I will try to find else I can talk to them and keep it in my github. And can send you also if you want. > > The driver as it is now is quite horrible. Huge tables of raw data, > written directly to the registers. Lots of magic numbers all around. > Even with a datasheet, presuming it's public and it contains all those > values, the driver is rather unmaintainable. > > All those need to be sorted out for the DRM driver anyway, so maybe it's > better to clean up the fb driver first. Ok. I never looked at them to see how they can be made better. I will see. regards sudip