From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756616AbbIYOVs (ORCPT ); Fri, 25 Sep 2015 10:21:48 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36099 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756500AbbIYOVg (ORCPT ); Fri, 25 Sep 2015 10:21:36 -0400 Date: Fri, 25 Sep 2015 16:21:33 +0200 From: Thierry Reding To: Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] drm/imx: Build monolithic driver Message-ID: <20150925142133.GA22463@ulmo> References: <1443114161-7965-1-git-send-email-thierry.reding@gmail.com> <1443114161-7965-3-git-send-email-thierry.reding@gmail.com> <1443165366.4397.4.camel@pengutronix.de> <20150925121735.GA30567@ulmo> <1443186558.4397.72.camel@pengutronix.de> <1443186834.4397.76.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <1443186834.4397.76.camel@pengutronix.de> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 25, 2015 at 03:13:54PM +0200, Philipp Zabel wrote: > Am Freitag, den 25.09.2015, 15:09 +0200 schrieb Philipp Zabel: > > Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding: > > > I think you gain much less by splitting up than you realize. Compare > > > this from before the series: > > >=20 > > > $ du -ch drivers/gpu/drm/imx/*.ko > > > 8.0K drivers/gpu/drm/imx/dw_hdmi-imx.ko > >=20 > > Oh right, I didn't realize that this is just the shim. The bulk of the > > HDMI driver is in bridge/dw_hdmi.ko. > >=20 > > > 16K drivers/gpu/drm/imx/imxdrm.ko > > > 16K drivers/gpu/drm/imx/imx-ipuv3-crtc.ko > > > 12K drivers/gpu/drm/imx/imx-ldb.ko > > > 12K drivers/gpu/drm/imx/imx-tve.ko > > > 8.0K drivers/gpu/drm/imx/parallel-display.ko > > > 72K total > > [...] > > > with this after the series: > > >=20 > > > $ du -ch drivers/gpu/drm/imx/*.ko > > > 44K drivers/gpu/drm/imx/imx-drm.ko > > > 44K total > > [...] > > > There are other things to consider as well, such as the additional > > > memory overhead caused by merely having multiple modules, or all of t= he > > > exported functions that unnecessarily clutter up the symbol table, and > > > which end up slowing down every symbol lookup. > >=20 > > Thanks, can't argue with those numbers. > > I'll queue patches 3 and 4 for imx-drm. >=20 > Wait, I won't because they depend on the helper function in patch 1. >=20 > Acked-by: Philipp Zabel >=20 > then. Can I get a stable tag so I can solve potential merge conflicts in > imx-drm-core.c? Let's see what Greg thinks about patch 1. There are a bunch of other drivers that can use these helpers, so it might be best to get the helper merged first and hold off on the depending patches until the next release. I'll let you know when we've figured out how to merge this. Thierry --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWBVhqAAoJEN0jrNd/PrOh6m4P/Av/89TRO8Uij7SoQdPD82mZ UahdTsJ71qaH7zbSSr4tRsmZCyj3fAZb8T4R6eq+MhDU1zrfb9yBDmb9S/GI49gu MrgL8wsmiYQC1U1VqZY04UjKKbKFkaoDYByP53YAoRYxKjkeiliyihCu3rp3nLjD Q1FvxcsWs8edkVNMXanU3djpVWqjA7fztdW7tl3T7aq1QsEFxUMVQhCxu1Sc5qXO ZzM/fIeGqawf9neIUj0/tEk9dCS4le/tKaz2BNIxzF2TyeNuk7vO5/1Ixdm7CYeP MJ1j0aCf0+n/6ydR+4sfH2xAeLYFr31sN1PM7fePoAMLNjd2XkRArN0zIyrO3WZ1 eNgaxUWnsEzPH5wPNuDqcdWSDT4LNVG8tc7BiKOrcr03It2THeysxL6Ai44F2ZPv CAtfFwxi5YZqRrG9+cyNdLgCBKIlJZsSVYY/Nt+1n+qF4S79ZtmGD3sMUv6rnOsS v2yCTAw9JXyrxQkuzETeLfg/oef64yJdWit5aN1Jw+mJFzK1vfbaAbLB6SWDeR7B fKIgXvDskWqqHoCHEIuMLpQfgTuFbX0VDl2pSLXohq8Ci9sZ4iUNRfp4rkWXrS6x oPq/BcAMrPH7ZnNYnJN2k+a7XVwf3hDhXkL9x/t8rkELyP1z79fvrZj0nD1NIO9C T9WT4ty1WH5gZAQK1FxP =t3zs -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--