From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756904AbbIYPoy (ORCPT ); Fri, 25 Sep 2015 11:44:54 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52991 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756518AbbIYPow (ORCPT ); Fri, 25 Sep 2015 11:44:52 -0400 Date: Fri, 25 Sep 2015 17:44:15 +0200 From: Darren Hart To: Michael Ellerman Cc: "long.wanglong" , shuahkh@osg.samsung.com, sam.bobroff@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, paulus@samba.or, khandual@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com, anton@samba.org, dvhart@linux.intel.com, tglx@linutronix.de, john.stultz@linaro.org, linux-kernel@vger.kernel.org, wanglong@laoqinren.net, linux-doc@vger.kernel.org, peifeiyue@huawei.com Subject: Re: [PATCH] kselftest: using built-in rule when delete file Message-ID: <20150925154415.GC38748@vmdeb7> References: <1443001211-119624-1-git-send-email-long.wanglong@huawei.com> <1443059210.21433.1.camel@ellerman.id.au> <56035A71.9040301@huawei.com> <1443060467.21433.3.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443060467.21433.3.camel@ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 12:07:47PM +1000, Michael Ellerman wrote: > On Thu, 2015-09-24 at 10:05 +0800, long.wanglong wrote: > > On 2015/9/24 9:46, Michael Ellerman wrote: > > > On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote: > > >> Use make's built-in rules to when delete a file > > >> or delete files. > > > > > > It's not a built-in rule, it's a variable. > > > > Sorry，I did not describe clearly. It is a variable used as > > name of program in built-in rules. > > > > > Personally I think using rm directly is clearer, but I guess this is fine. Do > > > you actually want to override $RM ? > > > > So far, I do not want to override $(RM). But I found that some test's Makefile > > using *$(RM)* while the other's using *rm -f*, I think it is better to use one > > of them in all unit tests. Agreed, consistency is good. > > > > Do you think which one is better? > > I prefer just using rm -f, because it's less magic, everyone knows what it does. > Also agreed, it's explicit and perfectly functional. -- Darren Hart Intel Open Source Technology Center