public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: sasha.levin@oracle.com, broonie@opensource.wolfsonmicro.com,
	Julia Lawall <julia.lawall@lip6.fr>,
	linux-kernel@vger.kernel.org, fengguang.wu@intel.com
Subject: Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Date: Sat, 26 Sep 2015 19:21:28 +0200	[thread overview]
Message-ID: <20150926172127.GB22315@earth> (raw)
In-Reply-To: <20150922172823.GA13598@ubuntu-vm>

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Hi Valentin,

On Tue, Sep 22, 2015 at 07:28:23PM +0200, Valentin Rothberg wrote:
> From bceb7cace76aba9212db56be939bfecaacb75bc2 Mon Sep 17 00:00:00 2001
> From: Valentin Rothberg <valentinrothberg@gmail.com>
> Date: Tue, 22 Sep 2015 19:00:40 +0200
> Subject: [PATCH] wm831x_power: Use IRQF_ONESHOT to request threaded IRQs
> 
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
> 
> scripts/coccinelle/misc/irqf_oneshot.cocci detected this issue.
> 
> Fixes: b5874f33bbaf ("wm831x_power: Use genirq")
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>

Thanks, queued.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-09-26 17:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 17:28 drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Valentin Rothberg
2015-09-22 19:41 ` Sasha Levin
2015-09-22 20:01   ` Valentin Rothberg
2015-09-26 16:52     ` Sebastian Reichel
2015-09-26 17:21 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150926172127.GB22315@earth \
    --to=sre@kernel.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=fengguang.wu@intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox