Re: [PATCH] cxl: Don't remove AFUs/vPHBs in cxl_reset

Daniel Axtens
2015-09-29T05:27:53Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

Yep, this is OK. It broke because vPHB support was added in 4.2.

The commit message and title are technically slightly wrong as there are
no vPHBs, but I don't think that's serious.

Thanks Sudip!

Regards,
Daniel

Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

> From: Daniel Axtens <dja@axtens.net>
>
> commit 4e1efb403c1c016ae831bd9988a7d2e5e0af41a0 upstream.
>
> If the driver doesn't participate in EEH, the AFUs will be removed
> by cxl_remove, which will be invoked by EEH.
>
> If the driver does particpate in EEH, the vPHB needs to stick around
> so that the it can particpate.
>
> In both cases, we shouldn't remove the AFU/vPHB.
>
> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> Cc: <stable@vger.kernel.org> # 4.1.9
> ---
> drivers/misc/cxl/pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 9eab76c..4f1b0bd 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -781,9 +781,6 @@ int cxl_reset(struct cxl *adapter)
>
> dev_info(&dev->dev, "CXL reset\n");
>
> - for (i = 0; i < adapter->slices; i++)
> - cxl_remove_afu(adapter->afu[i]);
> -
> /* pcie_warm_reset requests a fundamental pci reset which includes a
> * PERST assert/deassert. PERST triggers a loading of the image
> * if "user" or "factory" is selected in sysfs */
> --
> 1.9.1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJWCiE8AAoJEPC3R3P2I92FyAMP+gKCBfUwiJFkwBUq/pLOfJ4k
AenWGoUCgkFmbJxNwdbNaDq5kmXmpU0Amz+1AO20d8e4EqLCGfYML+g/mfS4HJ3f
fJZzuomwIrU1lTxi69jMMbKNKEruUzrkNw10/99NkxsTESE97FyVwry2K7kprW4c
Y7EAG9pvsXW+/OKhnExLDrz0cYppdgtTIy16Ic+krMDYpCANiMJQNw8xoXOfU7m+
ETZc6dj3kz6uonj8HHvktjpU1Fy+0aLnbr5Ts57BRxkttnf4FSrFkKV4tHCUoMt1
g8pauoqxuozWiIiRfB1l3fVvozqsqhMFU7JFgnu6MPruYo2fsp4qzvtxZgn8XTzI
LfkPFFPR1+l/s6DlA+xu8sF2Q801DkN0/vZbD86ar87tWWOwAXLJRwMWRff0LKIK
sXBa4D6//i3hfgjcUwsq19dkOwkgkAFpnORh6c1eV9VPufs3BHARg30jRAAHDJnS
D9+xZL2oPtk3Zt1OoCKnesj9CuWi1s8+u6b+j2HDL2pubf/anvIPqupTNrCZklX2
vL65KDe+jE+vj8Y+thsm95NNYM6QlgutDufKP2f4iP4/1jpx2hqx5Hu4tt7fZ5Ah
skdQwn/5IEo7yvZk1KX8di+LtgG8IfpSjKhUNKU9Ul7ZzXuOI+RbgqKAt7Pc5rfn
RK6bo49oUSroP0iu4eCH
=hbHb
-----END PGP SIGNATURE-----