From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbI0U2l (ORCPT ); Sun, 27 Sep 2015 16:28:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbbI0U2k (ORCPT ); Sun, 27 Sep 2015 16:28:40 -0400 Date: Sun, 27 Sep 2015 22:28:33 +0200 From: Jiri Olsa To: He Kuang Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com, wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms of hw/sw events Message-ID: <20150927202833.GF24007@krava.redhat.com> References: <1443179511-59238-1-git-send-email-hekuang@huawei.com> <1443179511-59238-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443179511-59238-2-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 11:11:49AM +0000, He Kuang wrote: SNIP > +char *parse_events_formats_error_string(char *additional_terms) > +{ > + char *str; > + static const char *static_terms = "config,config1,config2,name," > + "period,freq,branch_type,time," > + "call-graph,stack-size\n"; > + > + /* valid terms */ > + if (additional_terms) { > + if (!asprintf(&str, "valid terms: %s,%s", > + additional_terms, static_terms)) > + goto fail; > + free(additional_terms); > + } else { > + if (!asprintf(&str, "valid terms: %s", static_terms)) > + goto fail; > + } > + return str; > + > +fail: > + return NULL; > +} also please change the comment in the flex file thanks, jirka --- diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l index 936d566f48d8..c29832bce496 100644 --- a/tools/perf/util/parse-events.l +++ b/tools/perf/util/parse-events.l @@ -174,7 +174,7 @@ modifier_bp [rwx]{1,3} { /* - * Please update formats_error_string any time + * Please update parse_events_formats_error_string any time * new static term is added. */ config { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_CONFIG); }