From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbbI0Udn (ORCPT ); Sun, 27 Sep 2015 16:33:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37729 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbbI0Udm (ORCPT ); Sun, 27 Sep 2015 16:33:42 -0400 Date: Sun, 27 Sep 2015 22:33:34 +0200 From: Jiri Olsa To: He Kuang Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com, wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] perf tools: Adds the tracepoint name parsing support Message-ID: <20150927203334.GH24007@krava.redhat.com> References: <1443179511-59238-1-git-send-email-hekuang@huawei.com> <1443179511-59238-3-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443179511-59238-3-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 11:11:50AM +0000, He Kuang wrote: > Adds rules for parsing tracepoint names. Change rules of tracepoint > which derives of PE_NAMEs into tracepoint names directly, so adding > more rules based on tracepoint names will be easier. > > Signed-off-by: He Kuang > --- > tools/perf/util/parse-events.y | 38 +++++++++++++++++++++++--------------- > 1 file changed, 23 insertions(+), 15 deletions(-) > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index 8bcc458..279c01c 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -67,6 +67,7 @@ static inc_group_count(struct list_head *list, > %type event_legacy_cache > %type event_legacy_mem > %type event_legacy_tracepoint > +%type __event_legacy_tracepoint > %type event_legacy_numeric > %type event_legacy_raw > %type event_def > @@ -84,6 +85,10 @@ static inc_group_count(struct list_head *list, > u64 num; > struct list_head *head; > struct parse_events_term *term; > + struct tracepoint_name{ > + char *sys; > + char *event; > + } tracepoint_name; > } > %% > > @@ -368,36 +373,39 @@ PE_PREFIX_MEM PE_VALUE sep_dc > } > > event_legacy_tracepoint: > -PE_NAME '-' PE_NAME ':' PE_NAME > +__event_legacy_tracepoint > { > struct parse_events_evlist *data = _data; > struct parse_events_error *error = data->error; > struct list_head *list; > - char sys_name[128]; > - snprintf(&sys_name, 128, "%s-%s", $1, $3); > > ALLOC_LIST(list); > - if (parse_events_add_tracepoint(list, &data->idx, &sys_name, $5, error)) { > + if (parse_events_add_tracepoint(list, &data->idx, $1.sys, $1.event, > + error)) { > if (error) > error->idx = @1.first_column; > return -1; > } > $$ = list; > } > + > +__event_legacy_tracepoint: how about the tracepoint_name label change? thanks, jirka