From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149AbbI0UmG (ORCPT ); Sun, 27 Sep 2015 16:42:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39900 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbbI0UmE (ORCPT ); Sun, 27 Sep 2015 16:42:04 -0400 Date: Sun, 27 Sep 2015 22:41:54 +0200 From: Jiri Olsa To: He Kuang Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com, wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] perf tools: Enable event_config terms to tracepoint events Message-ID: <20150927204154.GJ24007@krava.redhat.com> References: <1443179511-59238-1-git-send-email-hekuang@huawei.com> <1443179511-59238-4-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443179511-59238-4-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2015 at 11:11:51AM +0000, He Kuang wrote: SNIP > > +static int config_term_tracepoint(struct perf_event_attr *attr, > + struct parse_events_term *term, > + struct parse_events_error *err) > +{ > + switch (term->type_term) { > + case PARSE_EVENTS__TERM_TYPE_CALLGRAPH: > + case PARSE_EVENTS__TERM_TYPE_STACKSIZE: > + return config_term_common(attr, term, err); > + default: > + if (err) { > + err->idx = term->err_term; > + err->str = strdup("unknown term"); > + err->help = strdup( > + "valid terms: call-graph,stack-size\n"); please keep that on one line, we dont follow 80 chars rule strictly if it results in ugly formatting like above thanks, jirka