From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753775AbbI1AFU (ORCPT ); Sun, 27 Sep 2015 20:05:20 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35118 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753272AbbI1AFT (ORCPT ); Sun, 27 Sep 2015 20:05:19 -0400 Date: Sun, 27 Sep 2015 17:05:15 -0700 From: Brian Norris To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Message-ID: <20150928000515.GA34421@google.com> References: <1440961710-17347-1-git-send-email-robert.jarzmik@free.fr> <87a8s9exxg.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a8s9exxg.fsf@belgarion.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 26, 2015 at 10:19:07PM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > After the conversion of pxa architecture to common clock framework, the > > NAND clock can be disabled on driver exit. > > > > In this case, it happens that if the driver used the NAND and set the > > DFI arbitration bit, the next access to a static memory controller area, > > such as an ethernet card, will stall the system bus, and the core will > > be stalled forever. > > > > This is especially true on pxa31x SoCs, where the NDCR was augmented > > with a new bit to prevent this lockups by giving full ownership of the > > DFI arbiter to the SMC, in change SCr#6. > > > > Fix this by clearing the DFI arbritration bit in driver exit. This > > effectively prevents a lockup on zylonite when removing pxa3xx-nand > > module, and using ethernet afterwards. > > > > Signed-off-by: Robert Jarzmik > Hi Brian, > > Are you happy with this patch, and if so could you queue it please ? It looks OK to me, but it doesn't apply to the latest l2-mtd.git. Am I missing something? I didn't try too hard to work out the conflict myself. Brian