From: Brian Norris <computersforpeace@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine
Date: Sun, 27 Sep 2015 17:49:22 -0700 [thread overview]
Message-ID: <20150928004922.GA75400@google.com> (raw)
In-Reply-To: <20150928001856.GB34421@google.com>
On Sun, Sep 27, 2015 at 05:18:56PM -0700, Brian Norris wrote:
> Sparse has one complaint, but I have no others:
>
> On Sun, Sep 06, 2015 at 03:12:47PM +0200, Robert Jarzmik wrote:
> > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> > index 2f39bfe34584..1e9d462065e8 100644
> > --- a/drivers/mtd/nand/pxa3xx_nand.c
> > +++ b/drivers/mtd/nand/pxa3xx_nand.c
> > @@ -15,7 +15,9 @@
> ...
> > @@ -564,57 +567,61 @@ static void handle_data_pio(struct pxa3xx_nand_info *info)
> [...]
> > +static void start_data_dma(struct pxa3xx_nand_info *info)
> > +{
> > + enum dma_data_direction direction;
>
> I think this should be dma_transfer_direction. See warning below.
I just fixed this up and pushed to l2-mtd.git. I can revert and apply
something different if you'd like.
Regards,
Brian
next prev parent reply other threads:[~2015-09-28 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 13:12 [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine Robert Jarzmik
2015-09-26 20:08 ` Robert Jarzmik
2015-09-28 0:18 ` Brian Norris
2015-09-28 0:49 ` Brian Norris [this message]
2015-09-28 7:47 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928004922.GA75400@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox