From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754346AbbI1AtZ (ORCPT ); Sun, 27 Sep 2015 20:49:25 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33719 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532AbbI1AtY (ORCPT ); Sun, 27 Sep 2015 20:49:24 -0400 Date: Sun, 27 Sep 2015 17:49:22 -0700 From: Brian Norris To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine Message-ID: <20150928004922.GA75400@google.com> References: <1441545167-23383-1-git-send-email-robert.jarzmik@free.fr> <20150928001856.GB34421@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150928001856.GB34421@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2015 at 05:18:56PM -0700, Brian Norris wrote: > Sparse has one complaint, but I have no others: > > On Sun, Sep 06, 2015 at 03:12:47PM +0200, Robert Jarzmik wrote: > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > > index 2f39bfe34584..1e9d462065e8 100644 > > --- a/drivers/mtd/nand/pxa3xx_nand.c > > +++ b/drivers/mtd/nand/pxa3xx_nand.c > > @@ -15,7 +15,9 @@ > ... > > @@ -564,57 +567,61 @@ static void handle_data_pio(struct pxa3xx_nand_info *info) > [...] > > +static void start_data_dma(struct pxa3xx_nand_info *info) > > +{ > > + enum dma_data_direction direction; > > I think this should be dma_transfer_direction. See warning below. I just fixed this up and pushed to l2-mtd.git. I can revert and apply something different if you'd like. Regards, Brian