From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757211AbbI1Jnv (ORCPT ); Mon, 28 Sep 2015 05:43:51 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34842 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757058AbbI1Jnt (ORCPT ); Mon, 28 Sep 2015 05:43:49 -0400 Date: Mon, 28 Sep 2015 11:43:34 +0200 From: LABBE Corentin To: Christophe Leroy Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 1/4] crypto: talitos: dma_map_sg can handle chained SG Message-ID: <20150928094334.GA15502@Red> References: <1443009328-12478-1-git-send-email-clabbe.montjoie@gmail.com> <1443009328-12478-2-git-send-email-clabbe.montjoie@gmail.com> <560295FA.7070005@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <560295FA.7070005@c-s.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 02:07:22PM +0200, Christophe Leroy wrote: > > Le 23/09/2015 13:55, LABBE Corentin a écrit : > > The talitos driver use two dma_map_sg path > > according to SG are chained or not. > > Since dma_map_sg can handle both case, clean the code with all > > references to sg chained. > > > > Thus removing talitos_map_sg, talitos_unmap_sg_chain > > and sg_count functions. > > > > > Shouldn't the replacement of sg_count() by sg_nents_for_len() be part > of second patch ? > No because I remove also the chained argument of sg_count, so splitting this patch with a dedicated patch for removing sg_count is not good. Regards