From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932974AbbI1LX1 (ORCPT ); Mon, 28 Sep 2015 07:23:27 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:32868 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbbI1LX0 (ORCPT ); Mon, 28 Sep 2015 07:23:26 -0400 Date: Mon, 28 Sep 2015 12:23:22 +0100 From: Lee Jones To: Ben Hutchings Cc: Maxim Levitsky , Roger Tseng , LKML Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Message-ID: <20150928112322.GR27197@x1> References: <1443400461.2517.22.camel@decadent.org.uk> <20150928103444.GP27197@x1> <1443438600.2517.33.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443438600.2517.33.camel@decadent.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2015, Ben Hutchings wrote: > On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > > The subsystem is missing from the subject line. > > > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the load average (for > > > bug-compatibility with Unix). A load average of ~1 on a system > > > that > > > should be idle is somewhat alarming. > > > > > > Change the sleep to be interruptible, but still ignore signals. > > > > > > A better fix might be to replace this loop with a delayed work > > > item. > > > > > > References: https://bugs.debian.org/765717 > > > Signed-off-by: Ben Hutchings > > > > How was this patch made? Where's the diff etc? > > With quilt. Old Skool! ;) > > Why was this patch sent to me? > > I think I must have added you previously as MFD maintainer, but as this > doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry > to bother you. No worries. > > > --- > > > --- a/drivers/memstick/host/rtsx_usb_ms.c > > > +++ b/drivers/memstick/host/rtsx_usb_ms.c > > > @@ -706,7 +706,8 @@ poll_again: > > > if (host->eject) > > > break; > > > > > > - msleep(1000); > > > + if (msleep_interruptible(1000)) > > > + flush_signals(current); > > > } > > > > > > complete(&host->detect_ms_exit); > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog