From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932931AbbI1LWP (ORCPT ); Mon, 28 Sep 2015 07:22:15 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56699 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932560AbbI1LWN convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2015 07:22:13 -0400 Date: Mon, 28 Sep 2015 13:21:59 +0200 From: Boris Brezillon To: "Bean Huo =?UTF-8?B?6ZyN5paM5paM?= (beanhuo)" Cc: "dedekind1@gmail.com" , "adrian.hunter@intel.com" , "computersforpeace@gmail.com" , "baruch@tkos.co.il" , "asierra@xes-inc.com" , "guz.fnst@cn.fujitsu.com" , "gsi@denx.de" , "richard@nod.at" , David Woodhouse , "linux-mtd@lists.infradead.org" , "Frank Liu =?UTF-8?B?5YiY576k?= (frankliu)" , Andrea Scian , "Peter Pan =?UTF-8?B?5r2Y5p+P5a6P?= (peterpan)" , "Karl Zhang =?UTF-8?B?5byg5Y+M6ZSj?= (karlzhang)" , Iwo Mergler , "Jeff Lauruhn (jlauruhn)" , Stefan Roese , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer Message-ID: <20150928132159.4738f573@bbrezillon> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2015 07:02:52 +0000 Bean Huo 霍斌斌 (beanhuo) wrote: > Add hook for UBI bakvol in ubifs layer. > > open/close bakvol operation in ubifs mount. > > Signed-off-by: Bean Huo > --- > fs/ubifs/super.c | 6 ++++++ > fs/ubifs/ubifs.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 9547a278..f3bf548 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -1463,6 +1463,8 @@ static int mount_ubifs(struct ubifs_info *c) > dbg_gen("max. seq. number: %llu", c->max_sqnum); > dbg_gen("commit number: %llu", c->cmt_no); > > + init_bakvol(c->ubi, 1); This function is implemented in patch 9 and you're using it here, which means your series is not bisectable. Also, do we really want to let UBIFS decide whether this feature should be enabled or not for the whole UBI device? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com