From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbbI1TjZ (ORCPT ); Mon, 28 Sep 2015 15:39:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbbI1TjX (ORCPT ); Mon, 28 Sep 2015 15:39:23 -0400 Date: Mon, 28 Sep 2015 21:39:18 +0200 From: Jiri Olsa To: He Kuang Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com, wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] perf tools: Adds the config_term callback for different type events Message-ID: <20150928193918.GA18363@krava.redhat.com> References: <1443412336-120050-1-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443412336-120050-1-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2015 at 03:52:13AM +0000, He Kuang wrote: > Currently, function config_term() is used for checking config terms of > all types of events, while unknown terms is not reported as an error > because pmu events have valid terms in sysfs. But this is wrong when > unknown terms are specificed to hw/sw events. This patch Adds the > config_term callback so we can use separate check routines for each > type of events. > > Signed-off-by: He Kuang Acked-by: Jiri Olsa thanks, jirka