From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753009AbbI1TkW (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 15:40:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59443 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752213AbbI1TkU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 15:40:20 -0400
Date: Mon, 28 Sep 2015 21:40:16 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
        jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com,
        wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] perf tools: Enable event_config terms to
 tracepoint events
Message-ID: <20150928194016.GD18363@krava.redhat.com>
References: <1443412336-120050-1-git-send-email-hekuang@huawei.com>
 <1443412336-120050-4-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443412336-120050-4-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 28, 2015 at 03:52:16AM +0000, He Kuang wrote:
> This patch enable config terms for tracepoint perf events. Valid terms
> for tracepoint events are call-graph and stack-size, so we can use
> different callgraph settings for each event and eliminate unnecessary
> overhead.
> 
> Here is an example for using different call-graph config for each
> tracepoint.
> 
>   $ perf record -e syscalls:sys_enter_write/call-graph=fp/
>                 -e syscalls:sys_exit_write/call-graph=no/
>                 dd if=/dev/zero of=test bs=4k count=10
> 
>   $ perf report --stdio
> 
>   #
>   # Total Lost Samples: 0
>   #
>   # Samples: 13  of event 'syscalls:sys_enter_write'
>   # Event count (approx.): 13
>   #
>   # Children      Self  Command  Shared Object       Symbol
>   # ........  ........  .......  ..................  ......................
>   #
>       76.92%    76.92%  dd       libpthread-2.20.so  [.] __write_nocancel
>                    |
>                    ---__write_nocancel
> 
>       23.08%    23.08%  dd       libc-2.20.so        [.] write
>                    |
>                    ---write
>                       |
>                       |--33.33%-- 0x2031342820736574
>                       |
>                       |--33.33%-- 0xa6e69207364726f
>                       |
>                        --33.33%-- 0x34202c7320393039
>   ...
> 
>   # Samples: 13  of event 'syscalls:sys_exit_write'
>   # Event count (approx.): 13
>   #
>   # Children      Self  Command  Shared Object       Symbol
>   # ........  ........  .......  ..................  ......................
>   #
>       76.92%    76.92%  dd       libpthread-2.20.so  [.] __write_nocancel
>       23.08%    23.08%  dd       libc-2.20.so        [.] write
>        7.69%     0.00%  dd       [unknown]           [.] 0x0a6e69207364726f
>        7.69%     0.00%  dd       [unknown]           [.] 0x2031342820736574
>        7.69%     0.00%  dd       [unknown]           [.] 0x34202c7320393039
> 
> Signed-off-by: He Kuang <hekuang@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka