From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753244AbbI1VI3 (ORCPT ); Mon, 28 Sep 2015 17:08:29 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:60701 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbbI1VI1 (ORCPT ); Mon, 28 Sep 2015 17:08:27 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 28 Sep 2015 14:08:22 -0700 From: "Paul E. McKenney" To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan Subject: Re: [PATCH v2] kernel: make rcu/tree_trace.c explicitly non-modular Message-ID: <20150928210822.GC5182@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1443395697-10266-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443395697-10266-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15092821-0017-0000-0000-00000E37EB18 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2015 at 07:14:57PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > init/Kconfig:config TREE_RCU_TRACE > init/Kconfig: def_bool RCU_TRACE && ( TREE_RCU || PREEMPT_RCU ) > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the file there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. We could > consider moving this to an earlier initcall if desired. > > We don't replace module.h with init.h since the file already has that. > We also delete the moduleparam.h include that is left over from > commit 64db4cfff99c04cd5f550357edcc8780f96b54a2 (""Tree RCU": scalable > classic RCU implementation") since it is not needed here either. > > We morph some tags like MODULE_AUTHOR into the comments at the top of > the file for documentation purposes. > > Cc: "Paul E. McKenney" > Cc: Josh Triplett > Reviewed-by: Josh Triplett > Cc: Steven Rostedt > Cc: Mathieu Desnoyers > Cc: Lai Jiangshan > Signed-off-by: Paul Gortmaker Queued for testing, thank you! If all goes well, this will go into 4.5. Thanx, Paul > --- > > [v2: integrate Josh feedback ; move info from MODULE tags into comments] > > kernel/rcu/tree_trace.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/kernel/rcu/tree_trace.c b/kernel/rcu/tree_trace.c > index 6fc4c5ff3bb5..4086f1f0fb4e 100644 > --- a/kernel/rcu/tree_trace.c > +++ b/kernel/rcu/tree_trace.c > @@ -1,5 +1,5 @@ > /* > - * Read-Copy Update tracing for classic implementation > + * Read-Copy Update tracing for hierarchical implementation. > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > @@ -16,6 +16,7 @@ > * http://www.gnu.org/licenses/gpl-2.0.html. > * > * Copyright IBM Corporation, 2008 > + * Author: Paul E. McKenney > * > * Papers: http://www.rdrop.com/users/paulmck/RCU > * > @@ -33,9 +34,7 @@ > #include > #include > #include > -#include > #include > -#include > #include > #include > #include > @@ -487,16 +486,4 @@ free_out: > debugfs_remove_recursive(rcudir); > return 1; > } > - > -static void __exit rcutree_trace_cleanup(void) > -{ > - debugfs_remove_recursive(rcudir); > -} > - > - > -module_init(rcutree_trace_init); > -module_exit(rcutree_trace_cleanup); > - > -MODULE_AUTHOR("Paul E. McKenney"); > -MODULE_DESCRIPTION("Read-Copy Update tracing for hierarchical implementation"); > -MODULE_LICENSE("GPL"); > +device_initcall(rcutree_trace_init); > -- > 2.6.0.rc3 >