From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754309AbbI2Aes (ORCPT ); Mon, 28 Sep 2015 20:34:48 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33287 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbbI2Aer (ORCPT ); Mon, 28 Sep 2015 20:34:47 -0400 Date: Mon, 28 Sep 2015 17:34:44 -0700 From: Brian Norris To: Robert Jarzmik Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 REBASED] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal Message-ID: <20150929003444.GS31505@google.com> References: <1443473811-14285-1-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443473811-14285-1-git-send-email-robert.jarzmik@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2015 at 10:56:51PM +0200, Robert Jarzmik wrote: > After the conversion of pxa architecture to common clock framework, the > NAND clock can be disabled on driver exit. > > In this case, it happens that if the driver used the NAND and set the > DFI arbitration bit, the next access to a static memory controller area, > such as an ethernet card, will stall the system bus, and the core will > be stalled forever. > > This is especially true on pxa31x SoCs, where the NDCR was augmented > with a new bit to prevent this lockups by giving full ownership of the > DFI arbiter to the SMC, in change SCr#6. > > Fix this by clearing the DFI arbritration bit in driver exit. This > effectively prevents a lockup on zylonite when removing pxa3xx-nand > module, and using ethernet afterwards. > > Signed-off-by: Robert Jarzmik > > --- > Since v1: add comment, switch to NFCV1/NCFV2 registers naming > Since v2: rebase on top of Brian's tree Applied to l2-mtd.git. Thanks.