From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754480AbbI2Ahb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 20:37:31 -0400
Received: from mail-pa0-f42.google.com ([209.85.220.42]:32780 "EHLO
	mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752887AbbI2Ah3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 20:37:29 -0400
Date: Mon, 28 Sep 2015 17:37:26 -0700
From: Brian Norris <computersforpeace@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: Destroy mtd_idr on module_exit
Message-ID: <20150929003726.GT31505@google.com>
References: <1436368534-30687-1-git-send-email-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436368534-30687-1-git-send-email-jthumshirn@suse.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 08, 2015 at 05:15:34PM +0200, Johannes Thumshirn wrote:
> Destroy mtd_idr on module_exit, reclaiming the allocated memory.
> 
> This was detected by the following semantic patch (written by Luis Rodriguez
> <mcgrof@suse.com>)
> <SmPL>
> @ defines_module_init @
> declarer name module_init, module_exit;
> declarer name DEFINE_IDR;
> identifier init;
> @@
> 
> module_init(init);
> 
> @ defines_module_exit @
> identifier exit;
> @@
> 
> module_exit(exit);
> 
> @ declares_idr depends on defines_module_init && defines_module_exit @
> identifier idr;
> @@
> 
> DEFINE_IDR(idr);
> 
> @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
> identifier declares_idr.idr, defines_module_exit.exit;
> @@
> 
> exit(void)
> {
>  ...
>   idr_destroy(&idr);
>   ...
> }
> 
> @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
> identifier declares_idr.idr, defines_module_exit.exit;
> @@
> 
> exit(void)
> {
>  ...
>  +idr_destroy(&idr);
> }
> </SmPL>
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Applied to l2-mtd.git. Thanks.