From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932746AbbI2GlV (ORCPT ); Tue, 29 Sep 2015 02:41:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932696AbbI2GlP (ORCPT ); Tue, 29 Sep 2015 02:41:15 -0400 Date: Tue, 29 Sep 2015 07:41:09 +0100 From: Aaron Tomlin To: Ulrich Obergfell Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dzickus@redhat.com Subject: Re: [PATCH 4/5] watchdog: implement error handling in lockup_detector_suspend() Message-ID: <20150929064109.GJ25024@atomlin.usersys.redhat.com> References: <1443473052-3053-1-git-send-email-uobergfe@redhat.com> <1443473052-3053-5-git-send-email-uobergfe@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NY6JkbSqL3W9mApi" Content-Disposition: inline In-Reply-To: <1443473052-3053-5-git-send-email-uobergfe@redhat.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NY6JkbSqL3W9mApi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2015-09-28 22:44 +0200, Ulrich Obergfell wrote: > lockup_detector_suspend() now handles errors from watchdog_park_threads(). >=20 > Signed-off-by: Ulrich Obergfell > --- > kernel/watchdog.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 457113c..3bc22a9 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -707,6 +707,11 @@ int lockup_detector_suspend(void) > =20 > if (ret =3D=3D 0) > watchdog_suspended++; > + else { > + watchdog_disable_all_cpus(); > + pr_err("Failed to suspend lockup detectors, disabled\n"); > + watchdog_enabled =3D 0; > + } > =20 > mutex_unlock(&watchdog_proc_mutex); > =20 Reviewed-by: Aaron Tomlin --NY6JkbSqL3W9mApi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWCjKFAAoJEOLellgZzHfW2noP/AuSLxe8snTKUmx6pqwIjPhL NtIvDccqKrqb6PXo2ehDW2Imay9OZ/O4U+Ak4aMzdDxo/w2IgTZpXIsSiRoeL6F8 4solcrzA80OuZPiH4WRz5z9rTZvZUKsFLYiWC9SddwvfdjpXk88oIih7nlUK39W5 TH0UHtkKb1QUWAzcotvWnWIQ9myTEJFGnNY15+vSUIn8/lTSyijmvWTxUsjpz+bX yi9xT9RUkroHN1Dv3nTVPQEIlsEhoVXeOAHNEqQ8RXU0S8Da2LCCe5UcKlw/S+w8 huyjVEXZU1y+7QpfYy98Gk/ueLzmUfoibbLr1j2Ukv8qiTi57Vj+dJbg0WBi0Rim llM2Ve6Zbmi3kdO/yDUfiLNJfNHE8IwxGHtp91YId/UUfXSuCJry828cmd2Fmt4p FN9e0VSH/mZLCtzEvJNms04OYAdBeRFoD//4e/VuTDwqGjxHUyXOV9YD2xTwOWX4 lfZG6JVQuX1LURERQeEHNzIrKo8LT9PTTdioIEYSIZCiQeKfHoqwMHOrKZYUGX5o s55cEMfPMEjyQ1m+L6lKE8SSGbG+3BPaI4V8q5PD9Mpoti85Oy5uB1B8s8jEcHei nULNKIEK3ADOTr7sYoXJYbvLGlH6tCyp5nUktOXZq90E3qbhsfR0c1y+KEwFpBVf jBz//GZkHcd+DKXjeow3 =yvu5 -----END PGP SIGNATURE----- --NY6JkbSqL3W9mApi--