From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709AbbI2HEy (ORCPT ); Tue, 29 Sep 2015 03:04:54 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35216 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932578AbbI2HEe (ORCPT ); Tue, 29 Sep 2015 03:04:34 -0400 Date: Tue, 29 Sep 2015 09:07:28 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Emil Velikov , Tomi Valkeinen , Greg Kroah-Hartman , linux-fbdev , DRI Development , Thomas Petazzoni , Teddy Wang , Daniel Vetter , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Dave Airlie , Sudip Mukherjee Subject: Re: No more new fbdev drivers, please Message-ID: <20150929070728.GA3383@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Emil Velikov , Tomi Valkeinen , Greg Kroah-Hartman , linux-fbdev , DRI Development , Thomas Petazzoni , Teddy Wang , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Dave Airlie , Sudip Mukherjee References: <5603EC15.9090605@ti.com> <5607EA9C.7040909@tronnes.org> <5609C47A.6030809@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5609C47A.6030809@tronnes.org> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 12:51:38AM +0200, Noralf Trønnes wrote: > > Den 27.09.2015 18:08, skrev Emil Velikov: > >Hi all, > > > >On 27 September 2015 at 14:09, Noralf Trønnes wrote: > >>Den 24.09.2015 14:27, skrev Tomi Valkeinen: > >>>Hi all, > >>> > >>>fbdev is (more or less) maintained, but it's a deprecated framework. All > >>>new Linux display drivers should be done on DRM. > >>> > >>>So let's not add any more new fbdev drivers. > >>> > >>>I will continue to maintain the current fbdev drivers, and I don't mind > >>>adding some new features to those current drivers, as long as the amount > >>>of code required to add the features stays sensible. > >>> > >>>I see we have three fbdev drivers in staging: xgifb, fbtft and sm750fb, > >>>and the question is what to do with those. > >>> > >>>xgifb was added in 2010, and is still in staging. > >>> > >>>fbtft looks like maybe some kind of framework on top of fbdev, with > >>>fbtft specific subdrivers... I didn't look at it in detail, but my gut > >>>says "never". > >> > >>I have done some work [1] to try and make fbtft look more like the rest > >>of the kernel (doc [2]), but that work will result in an almost complete > >>rewrite of fbtft. > > From a very quick skim fbtft looks pretty much like drm/panel. We > >presently have 30+ 'simple' dsi panels, plus a bunch of spi ones. Have > >you had a look at these ? > > Thanks, that was useful. > I can use drm_panel to setup the controller (prepare) and do backlight > (enable/disable), but I need a way to send framebuffer changes. > I could do this: > > struct tinydrm_panel_funcs { > int (*update)(struct drm_framebuffer *fb, > struct drm_gem_cma_object *cma_obj, > unsigned flags, unsigned color, > struct drm_clip_rect *clips, unsigned num_clips); > }; > > struct tinydrm_panel { > struct drm_panel panel; > u32 width; > u32 height; > void *dev_private; > > const struct tinydrm_panel_funcs *funcs; > }; I'm not sure whether putting the manual-update stuff into drm_panel is a good idea - it's transport/bus (spi, dsi, ...) specific. Not sure how to best solve that. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch