From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934671AbbI2LIU (ORCPT ); Tue, 29 Sep 2015 07:08:20 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:3861 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934243AbbI2LIM (ORCPT ); Tue, 29 Sep 2015 07:08:12 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 29 Sep 2015 04:01:15 -0700 Date: Tue, 29 Sep 2015 13:07:25 +0200 From: Thierry Reding To: Philipp Zabel CC: Russell King - ARM Linux , Douglas Anderson , , , , , , , Subject: Re: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin Message-ID: <20150929110724.GA15035@ulmo.nvidia.com> References: <1442436098-26608-1-git-send-email-dianders@chromium.org> <20150921095104.GB20992@ulmo.nvidia.com> <20150921141541.GO21084@n2100.arm.linux.org.uk> <1443169791.4397.38.camel@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <1443169791.4397.38.camel@pengutronix.de> X-NVConfidentiality: public User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) X-Originating-IP: [10.2.68.55] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 25, 2015 at 10:29:51AM +0200, Philipp Zabel wrote: > Am Montag, den 21.09.2015, 15:15 +0100 schrieb Russell King - ARM Linux: > > On Mon, Sep 21, 2015 at 11:51:06AM +0200, Thierry Reding wrote: > > > On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote: > > > > There's a member in 'struct dw_hdmi' called cable_plugin. It's nev= er > > > > set to anything anywhere so thus is always false. There's a bit of= code > > > > checking it, but since it's always false this must be dead code. > > > > Eliminate it. > > > >=20 > > > > Note: if someone wants to figure out the intention of the original = code > > > > and implement whatever feature / fix was needed then we can drop th= is > > > > patch. The 'cable_plugin' member has been unused since the code was > > > > first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support). > > > >=20 > > > > Signed-off-by: Douglas Anderson > > > > --- > > > > drivers/gpu/drm/bridge/dw_hdmi.c | 9 --------- > > > > 1 file changed, 9 deletions(-) > > >=20 > > > Except for the CHROMIUM: prefix this looks good to me: > > >=20 > > > Reviewed-by: Thierry Reding >=20 > This seems to be similar to Sascha's "drm: bridge/dw_hdmi: remove unused > code" patch, except that the hdmi_disable_overflow_interrupts function > could be removed too. >=20 > > > Russell, do you have patches to this driver queued for v4.4 and plan = to > > > pick this up into your tree or should I take it? > >=20 > > My current patch stack for imx-drm related stuff looks like this at > > present: > > > > drm: bridge/dw_hdmi: place PHY into low power mode when disabled > > drm: bridge/dw_hdmi: start of support for pixel doubled modes > > drm: bridge/dw_hdmi: remove CEC engine register definitions > > drm: bridge/dw_hdmi-cec: add Designware HDMI CEC driver > > cec: add HDMI CEC input driver > > cec: add HDMI CEC core driver > > drm: bridge/dw_hdmi: replace CTS calculation for the ACR > > drm: bridge/dw_hdmi: remove ratio support from ACR code > > drm: bridge/dw_hdmi: adjust pixel clock values in N calculation > > drm: bridge/dw_hdmi: avoid being recursive in N calculation > > drm: bridge/dw_hdmi-ahb-audio: allow larger buffer sizes > > drm: bridge/dw_hdmi-ahb-audio: basic support for multi-channel PCM audio > > drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver > > drm: bridge/dw_hdmi-ahb-audio: add audio driver > > drm: bridge/dw_hdmi: improve HDMI enable/disable handling > > drm: bridge/dw_hdmi: add connector mode forcing > > drm: bridge/dw_hdmi: add support for interlaced video modes > > gpu: imx: fix support for interlaced modes > > gpu: imx: simplify sync polarity setting > >=20 > > I haven't yet decided what, if anything, from that stack I'm going to > > try to get into the next merge window. Given the lack of interest last > > time I posted these patches, I'm loosing interest myself in trying to > > get them merged, especially ones which are getting on for being 2 years > > old. >=20 > I'm still very interested to see at least the "gpu: imx: fix support for > interlaced modes" and "gpu: imx: simplify sync polarity setting" merged. > May I take them into the imx-drm tree separately? The "gpu: imx:" patches sound like they are standalone, so taking them through the imx-drm tree would be the easiest. Thierry --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWCnDpAAoJEN0jrNd/PrOhJV8P/AhfQQe2tWyLLmzlQWfioQyk qnY8nC5s9bUL4GWD0ox/TTtMW56AlOBxG22aZnYeG2lKpOq1AsBBDnzaIETMNjAU BpvmLNjzcuEYid110axuchL8B6XFQvqTEAMGx3QOnhF0PXzn6QeXRMipReatkN8r iK9qRn3U/l7vSKmib+iJpCA9o8tmp7aBHQK1jrkgoOQZkVIOkVZng9hsRtuyFga0 Wh9hDSIbRyCVzEsV6hkGAKnWH1BOWaBtL2rCWssv/nG11P14Rn27rWrkh6egI8GW K+v8bwgfo/SkzlGYpFHvMJKlbED5ojsnjoHQsmUr8l9wxBq8rRGpFyncOhFLDQB7 iCwrgpU8yOSfRN9elCaoYc8ZcxgVhX98Pak7Cf+f3IJ3ZTKjOgKaN7XjL3T9FmRT w+v7reomoHYKf66oKyVJgTuoC1YLpcdD+KiIU5lnLTjrmasyD1NUnOhkCoEVr0wY xd6TVvnxrW57S3wMaUc/K75O9dY7itLr0w0C3c4UeAF+mTkWwEJVvVrF9p9Z47h9 FcmZmwoaipNR5iwHVrHXUfUfMlDIUIpsq45toZtVJFcHnBjG3mcTjHy/JyGNFLK7 n1PkpY59IybxnbjAD4hNh41oF0yo4D3DGbC7racr/y4DMv0E95u0zYlOmQ8mE4Go tMXECzGaRxTmJh/0OMog =VG15 -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb--