From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joern Engel <joern@logfs.org>,
Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org, logfs@logfs.org, akpm@linux-foundation.org
Subject: Re: [PATCH] logfs: fix build warning
Date: Tue, 29 Sep 2015 18:18:07 +0530 [thread overview]
Message-ID: <20150929124747.GA6098@sudip-pc> (raw)
In-Reply-To: <20150915080315.GF9305@sudip-pc>
On Tue, Sep 15, 2015 at 01:33:15PM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 10, 2015 at 03:41:04PM +0530, Sudip Mukherjee wrote:
> > While building we were getting build warning of:
> >
> > fs/logfs/dev_bdev.c: In function '__bdev_writeseg':
> > include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > (void) (&_min1 == &_min2); \
> > fs/logfs/dev_bdev.c:84:14: note: in expansion of macro 'min'
> > max_pages = min(nr_pages, BIO_MAX_PAGES);
> >
> > fs/logfs/dev_bdev.c: In function 'do_erase':
> > include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > (void) (&_min1 == &_min2); \
> > fs/logfs/dev_bdev.c:174:14: note: in expansion of macro 'min'
> > max_pages = min(nr_pages, BIO_MAX_PAGES);
> >
> > Lets use min_t and mention the type.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> Hi,
> I know its too early to ping. But I can still see the build warnings
> with i386 allmodconfig. Build is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/80365417
Another gentle ping. Build warning still shows with next-20150929.
regards
sudip
next prev parent reply other threads:[~2015-09-29 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 10:11 [PATCH] logfs: fix build warning Sudip Mukherjee
2015-09-15 8:03 ` Sudip Mukherjee
2015-09-29 12:48 ` Sudip Mukherjee [this message]
2015-10-01 23:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929124747.GA6098@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logfs@logfs.org \
--cc=prasadjoshi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox