From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934829AbbI2Ms0 (ORCPT ); Tue, 29 Sep 2015 08:48:26 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34250 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934787AbbI2MsR (ORCPT ); Tue, 29 Sep 2015 08:48:17 -0400 Date: Tue, 29 Sep 2015 18:18:07 +0530 From: Sudip Mukherjee To: Joern Engel , Prasad Joshi Cc: linux-kernel@vger.kernel.org, logfs@logfs.org, akpm@linux-foundation.org Subject: Re: [PATCH] logfs: fix build warning Message-ID: <20150929124747.GA6098@sudip-pc> References: <1441879864-17487-1-git-send-email-sudipm.mukherjee@gmail.com> <20150915080315.GF9305@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150915080315.GF9305@sudip-pc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2015 at 01:33:15PM +0530, Sudip Mukherjee wrote: > On Thu, Sep 10, 2015 at 03:41:04PM +0530, Sudip Mukherjee wrote: > > While building we were getting build warning of: > > > > fs/logfs/dev_bdev.c: In function '__bdev_writeseg': > > include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] > > (void) (&_min1 == &_min2); \ > > fs/logfs/dev_bdev.c:84:14: note: in expansion of macro 'min' > > max_pages = min(nr_pages, BIO_MAX_PAGES); > > > > fs/logfs/dev_bdev.c: In function 'do_erase': > > include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default] > > (void) (&_min1 == &_min2); \ > > fs/logfs/dev_bdev.c:174:14: note: in expansion of macro 'min' > > max_pages = min(nr_pages, BIO_MAX_PAGES); > > > > Lets use min_t and mention the type. > > > > Signed-off-by: Sudip Mukherjee > > --- > Hi, > I know its too early to ping. But I can still see the build warnings > with i386 allmodconfig. Build is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/80365417 Another gentle ping. Build warning still shows with next-20150929. regards sudip