From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found
Date: Tue, 29 Sep 2015 15:50:34 +0200 [thread overview]
Message-ID: <20150929135033.GC7572@8bytes.org> (raw)
In-Reply-To: <1443511569-9187-1-git-send-email-bhe@redhat.com>
On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote:
> No need to continue the loop after it has been found.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> drivers/iommu/intel_irq_remapping.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 9ec4e0d..37b93f5 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope,
> if (ir_ioapic[count].iommu == iommu &&
> ir_ioapic[count].id == scope->enumeration_id)
> return 0;
> - else if (ir_ioapic[count].iommu == NULL && free == -1)
> + else if (ir_ioapic[count].iommu == NULL && free == -1) {
> free = count;
> + break;
> + }
> }
The purpose of the loop is also to avoid duplicate entries, so we need
to search it till the end, no?
Joerg
next prev parent reply other threads:[~2015-09-29 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 7:26 [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Baoquan He
2015-09-29 7:26 ` [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir Baoquan He
2015-09-29 13:55 ` Joerg Roedel
2015-09-29 13:50 ` Joerg Roedel [this message]
2015-09-29 15:04 ` [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929135033.GC7572@8bytes.org \
--to=joro@8bytes.org \
--cc=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox