From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965470AbbI2Nxt (ORCPT ); Tue, 29 Sep 2015 09:53:49 -0400 Received: from 8bytes.org ([81.169.241.247]:54318 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965320AbbI2Nug (ORCPT ); Tue, 29 Sep 2015 09:50:36 -0400 Date: Tue, 29 Sep 2015 15:50:34 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Message-ID: <20150929135033.GC7572@8bytes.org> References: <1443511569-9187-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443511569-9187-1-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote: > No need to continue the loop after it has been found. > > Signed-off-by: Baoquan He > --- > drivers/iommu/intel_irq_remapping.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index 9ec4e0d..37b93f5 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope, > if (ir_ioapic[count].iommu == iommu && > ir_ioapic[count].id == scope->enumeration_id) > return 0; > - else if (ir_ioapic[count].iommu == NULL && free == -1) > + else if (ir_ioapic[count].iommu == NULL && free == -1) { > free = count; > + break; > + } > } The purpose of the loop is also to avoid duplicate entries, so we need to search it till the end, no? Joerg