From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965388AbbI2Nzt (ORCPT ); Tue, 29 Sep 2015 09:55:49 -0400 Received: from 8bytes.org ([81.169.241.247]:54413 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965493AbbI2Nzl (ORCPT ); Tue, 29 Sep 2015 09:55:41 -0400 Date: Tue, 29 Sep 2015 15:55:38 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir Message-ID: <20150929135538.GD7572@8bytes.org> References: <1443511569-9187-1-git-send-email-bhe@redhat.com> <1443511569-9187-2-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443511569-9187-2-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 03:26:09PM +0800, Baoquan He wrote: > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index 37b93f5..0f441b7 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void) > if (!dmar_ir_support()) > return -ENODEV; > > - if (parse_ioapics_under_ir() != 1) { > + if (!parse_ioapics_under_ir()) { > pr_info("Not enabling interrupt remapping\n"); > goto error; > } > @@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void) > } > > if (!ir_supported) > - return 0; > + return -1; > > for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) { > int ioapic_id = mpc_ioapic_id(ioapic_idx); > @@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void) > } > } > > - return 1; > + return 0; Looks good, but -ENODEV is probably a better return value than -1. Joerg