From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965321AbbI2Och (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 10:32:37 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:37113 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965065AbbI2Oca (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 10:32:30 -0400
Date: Tue, 29 Sep 2015 16:32:27 +0200
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, oleg@redhat.com,
        umgwanakikbuti@gmail.com, tglx@linutronix.de, rostedt@goodmis.org
Subject: Re: [RFC][PATCH 03/11] sched: Robustify preemption leak checks
Message-ID: <20150929143226.GH31582@lerouge>
References: <20150929092825.540553633@infradead.org>
 <20150929093519.930244771@infradead.org>
 <20150929132552.GE31582@lerouge>
 <20150929142400.GK3816@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150929142400.GK3816@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 29, 2015 at 04:24:00PM +0200, Peter Zijlstra wrote:
> On Tue, Sep 29, 2015 at 03:25:53PM +0200, Frederic Weisbecker wrote:
> > On Tue, Sep 29, 2015 at 11:28:28AM +0200, Peter Zijlstra wrote:
> 
> > > +	if (unlikely(in_atomic_preempt_off() && prev->state != TASK_DEAD)) {
> > >  		__schedule_bug(prev);
> > > +		preempt_count_set(PREEMPT_DISABLED);
> > 
> > That one would be a bit fragile if we kept PREEMPT_ACTIVE, but since we are removing
> > it...
> 
> Right, let me move this patch after 7 (the one that stops setting
> PREEMPT_ACTIVE).

Perfect!