From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934708AbbI2Pt0 (ORCPT ); Tue, 29 Sep 2015 11:49:26 -0400 Received: from m12-17.163.com ([220.181.12.17]:35096 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932750AbbI2PtS (ORCPT ); Tue, 29 Sep 2015 11:49:18 -0400 Date: Tue, 29 Sep 2015 23:46:32 +0800 From: Yaowei Bai To: Boaz Harrosh Cc: viro@zeniv.linux.org.uk, bhalevy@primarydata.com, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check Message-ID: <20150929154631.GA6489@bbox> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443447836-5178-1-git-send-email-bywxiaobai@163.com> <560A9672.9@electrozaur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560A9672.9@electrozaur.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: EcCowAC32ylZsgpWj0QaDA--.935S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xr1ruF17Gr18GrWUtFWfAFb_yoWDGwc_G3 y0yw48Zws3Xw1fAFs5Cw13Jr9Ykan8Wr4kJFy3tr43X3Z5AFZ5ZrZ5Wws3AFy7uF47JrZx C34rua4rGF1I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU80ksPUUUUU== X-Originating-IP: [58.209.166.66] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiUB2ET1WBQV+gJgACsI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote: > On 09/28/2015 04:43 PM, Yaowei Bai wrote: > > As new_valid_dev always returns 1, so !new_valid_dev check is not > > needed, remove it. > > > > Signed-off-by: Yaowei Bai > > ACK-by: Boaz Harrosh Thanks. > > Please submit this through some General tree like the vfs or mm-tree This's my first fs-specific patch, so i think you mean i should cc vfs or mm-tree? > > Thanks > Boaz > > > --- > > fs/exofs/namei.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c > > index 09a6bb1..994e078 100644 > > --- a/fs/exofs/namei.c > > +++ b/fs/exofs/namei.c > > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, > > struct inode *inode; > > int err; > > > > - if (!new_valid_dev(rdev)) > > - return -EINVAL; > > - > > inode = exofs_new_inode(dir, mode); > > err = PTR_ERR(inode); > > if (!IS_ERR(inode)) { > >