From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/10] iommu/amd: copy old dev tables and do not touch dev tables
Date: Tue, 29 Sep 2015 18:08:08 +0200 [thread overview]
Message-ID: <20150929160808.GO3036@8bytes.org> (raw)
In-Reply-To: <1443076656-31776-8-git-send-email-bhe@redhat.com>
On Thu, Sep 24, 2015 at 02:37:33PM +0800, Baoquan He wrote:
> + if ( !translation_pre_enabled() ) {
> + iommu_disable(iommu);
> + iommu_init_flags(iommu);
> + iommu_set_device_table(iommu);
> + iommu_enable_command_buffer(iommu);
> + iommu_enable_event_buffer(iommu);
> + iommu_set_exclusion_range(iommu);
> + iommu_enable(iommu);
> + iommu_flush_all_caches(iommu);
> + } else {
> + copy_dev_tables();
> + copy_command_buffer();
> + copy_event_buffer();
> + }
Hmm, this leaves the old device-table in place and removes flushing the
iommu-caches in kdump kernel, right?
Joerg
next prev parent reply other threads:[~2015-09-29 16:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 6:37 [PATCH 00/10] Fix AMD IOMMU faults in kdump kernel Baoquan He
2015-09-24 6:37 ` [PATCH 01/10] iommu/amd: Use standard bitmap operation to set bitmap Baoquan He
2015-09-24 6:37 ` [PATCH 02/10] iommu/amd: Adjust functons which get first/last devid by reading pci config Baoquan He
2015-09-24 6:37 ` [PATCH 03/10] iommu/amd: Get the first/last device of iommu earlier Baoquan He
2015-09-24 6:37 ` [PATCH 04/10] iommu/amd: Detect pre enabled translation Baoquan He
2015-09-24 6:37 ` [PATCH 05/10] iommu/amd: Add function copy_dev_tables Baoquan He
2015-09-24 6:37 ` [PATCH 06/10] iommu/amd: Add functions copy_command_buffer/copy_event_buffer Baoquan He
2015-09-29 16:04 ` Joerg Roedel
2015-10-10 12:24 ` Baoquan He
2015-09-24 6:37 ` [PATCH 07/10] iommu/amd: copy old dev tables and do not touch dev tables Baoquan He
2015-09-29 16:08 ` Joerg Roedel [this message]
2015-10-10 12:28 ` Baoquan He
2015-09-24 6:37 ` [PATCH 08/10] iommu/amd: Do not update the information of domain to devtables before device driver init Baoquan He
2015-09-24 6:37 ` [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting Baoquan He
2015-09-29 16:09 ` Joerg Roedel
2015-10-10 12:30 ` Baoquan He
2015-09-24 6:37 ` [PATCH 10/10] iommu/amd: Copy the old ir table Baoquan He
2015-09-29 16:11 ` Joerg Roedel
2015-10-10 12:40 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929160808.GO3036@8bytes.org \
--to=joro@8bytes.org \
--cc=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).