From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934804AbbI2Qn2 (ORCPT ); Tue, 29 Sep 2015 12:43:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbbI2QnT (ORCPT ); Tue, 29 Sep 2015 12:43:19 -0400 Date: Tue, 29 Sep 2015 18:43:15 +0200 From: Greg KH To: Alexander Kapshuk Cc: linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH] ver_linux: uniform output across various linux distros Message-ID: <20150929164315.GA1300@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 06:36:12PM +0300, Alexander Kapshuk wrote: > I've reread 'Documentation/SubmittingPatches', and opted for method 1 > to create the patch. > > When you mentioned about the patch changing the formatting, were you > referring to the formatting of the actual script, or the output the > script generated? If it's the former, I'm not sure I'm clear on how to > keep separate the changes made to the code base from the changes in > the formatting of the new code base introduced by these changes. If > it's the latter, the overall output generated by the script is mostly > identical to that generated by the original implementation. > > If the patch below is still off the mark, I apologise for that, and > would appreciate being pointed out what else needs changing, when you > have the time. I understand you having more pressing matters to attend > to. > > Signed-off-by: Alexander Kapshuk This is the "oddest" changelog comments I've ever seen for a patch, it doesn't describe what it is doing at all :) Please fix up, and resend the whole thing correctly, so we can review that. thanks, greg k-h