From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935037AbbI2RbU (ORCPT ); Tue, 29 Sep 2015 13:31:20 -0400 Received: from mail.skyhub.de ([78.46.96.112]:45693 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934486AbbI2RbM (ORCPT ); Tue, 29 Sep 2015 13:31:12 -0400 Date: Tue, 29 Sep 2015 19:31:09 +0200 From: Borislav Petkov To: Ksenija =?utf-8?Q?Stanojevi=C4=87?= Cc: "H. Peter Anvin" , tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: include: asm: Fix build warning Message-ID: <20150929173109.GD3534@pd.tnic> References: <1443543946-8624-1-git-send-email-ksenija.stanojevic@gmail.com> <20150929170651.GA3551@pd.tnic> <560AC5AA.7080203@zytor.com> <20150929171627.GC3534@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 07:19:32PM +0200, Ksenija Stanojević wrote: > On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov wrote: > > On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote: > >> when building with: > >> make drivers/staging/oplc_dcon/olpc_dcon.o > >> I get this warnings. > > > > Yeah, you can't pick out single files from the source tree and try to > > build them and expect that to always work. That olpc_dcon think depends > > on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have > > enabled CONFIG_OLPC first. > > > Ok, thanks! Sure, no probs. Btw, if you really want to try to fix some bugs, you could try to build the kernel with make -j W=n 2>build-warnings.log where n is 1, 2 or 3 (or any subset of those) and try to analyze them. Look at the output in build-warnings.log and try to understand why the compiler is complaining and whether it makes sense. Some of them might be worth fixing. Most of them are bogus and/or fixing them would require just too much code changes for no real gain but some of the warnings do make sense. Also, you could do make allmodconfig before that so that you can build *everything* and catch all warnings. HTH. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.