From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753317AbbI2U4B (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 16:56:01 -0400
Received: from mail-pa0-f66.google.com ([209.85.220.66]:36703 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751031AbbI2Uzw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 16:55:52 -0400
Date: Tue, 29 Sep 2015 13:55:48 -0700
From: Brian Norris <computersforpeace@gmail.com>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>, David Woodhouse <dwmw2@infradead.org>,
        sebastian@breakpoint.cc, robh+dt@kernel.org, pawel.moll@arm.com,
        Mark Rutland <mark.rutland@arm.com>, ijc+devicetree@hellion.org.uk,
        Kumar Gala <galak@codeaurora.org>, Shawn Guo <shawn.guo@linaro.org>,
        kernel@pengutronix.de, boris.brezillon@free-electrons.com,
        marb@ixxat.de, aaron@tastycactus.com,
        Bill Pringlemeir <bpringlemeir@gmail.com>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        albert.aribaud@3adev.fr, Bill Pringlemeir <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v12 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610,
 MPC5125 and others
Message-ID: <20150929205548.GO31505@google.com>
References: <1441242397-870-1-git-send-email-stefan@agner.ch>
 <1441242397-870-2-git-send-email-stefan@agner.ch>
 <CALW4P+LDwFnCjOorh7iCr8TrUnync7a_zkdZ4Hp_91=60AtUQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALW4P+LDwFnCjOorh7iCr8TrUnync7a_zkdZ4Hp_91=60AtUQw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 04, 2015 at 07:10:10AM +0300, Alexey Klimov wrote:
> On Thu, Sep 3, 2015 at 4:06 AM, Stefan Agner <stefan@agner.ch> wrote:
> > --- /dev/null
> > +++ b/drivers/mtd/nand/vf610_nfc.c

> > +static int vf610_nfc_probe(struct platform_device *pdev)
> > +{
> > +       struct vf610_nfc *nfc;
> > +       struct resource *res;
> > +       struct mtd_info *mtd;
> > +       struct nand_chip *chip;
> > +       struct device_node *child;
> > +       const struct of_device_id *of_id;
> > +       int err = 0;
> 
> According to usage you don't need to initialize err to zero here.

Fixed this one.

> > +       int irq;
> > +
> > +       nfc = devm_kzalloc(&pdev->dev, sizeof(*nfc), GFP_KERNEL);
> > +       if (!nfc)
> > +               return -ENOMEM;
> > +
> > +       nfc->dev = &pdev->dev;
> > +       mtd = &nfc->mtd;
> > +       chip = &nfc->chip;
> > +
> > +       mtd->priv = chip;
> > +       mtd->owner = THIS_MODULE;
> > +       mtd->dev.parent = nfc->dev;
> > +       mtd->name = DRV_NAME;
> > +
> > +       irq = platform_get_irq(pdev, 0);
> > +       if (irq <= 0)
> > +               return -EINVAL;
> > +
> > +       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +       nfc->regs = devm_ioremap_resource(nfc->dev, res);
> > +       if (IS_ERR(nfc->regs))
> > +               return PTR_ERR(nfc->regs);
> > +
> > +       nfc->clk = devm_clk_get(&pdev->dev, NULL);
> > +       if (IS_ERR(nfc->clk))
> > +               return PTR_ERR(nfc->clk);
> > +
> > +       err = clk_prepare_enable(nfc->clk);
> > +       if (err) {
> > +               dev_err(nfc->dev, "Unable to enable clock!\n");
> > +               return err;
> > +       }
> 
> After fixing that feel free to use:
> 
> Reviewed-by: Alexey Klimov <klimov.linux@gmail.com>

Also, fixed up the nand_chip field name change (from 'dn' to
'flash_node'), and pushed to l2-mtd.git

Thanks,
Brian