From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbbI3FZs (ORCPT ); Wed, 30 Sep 2015 01:25:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37050 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbI3FZq (ORCPT ); Wed, 30 Sep 2015 01:25:46 -0400 Date: Tue, 29 Sep 2015 22:28:57 -0700 From: Andrew Morton To: Alexandru Moise <00moses.alexander00@gmail.com> Cc: mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com, js1304@gmail.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable Message-Id: <20150929222857.9f29351f.akpm@linux-foundation.org> In-Reply-To: <20150930051004.GA13409@gmail.com> References: <20150927210425.GA20155@gmail.com> <20150929160727.ef70acf2e44575e9470a4025@linux-foundation.org> <20150930051004.GA13409@gmail.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@gmail.com> wrote: > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc) > > > > > > static unsigned long zone_reclaimable_pages(struct zone *zone) > > > { > > > - int nr; > > > + unsigned long nr; > > > > > > nr = zone_page_state(zone, NR_ACTIVE_FILE) + > > > zone_page_state(zone, NR_INACTIVE_FILE); > > > > OK. > > > > Are you sure? Mel Gorman raised the following issue on patch 1/2: > > https://lkml.org/lkml/2015/9/29/253 __zone_watermark_ok() is very different from zone_reclaimable_pages().