From: Greg KH <gregkh@linuxfoundation.org>
To: Arjun Krishna Babu <arjunkrishnababu96@gmail.com>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
himani93@gmail.com, dilekuzulmez@gmail.com,
sakshi.april5@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Fixed two lines over 80 characters
Date: Wed, 30 Sep 2015 04:57:02 +0200 [thread overview]
Message-ID: <20150930025702.GA26143@kroah.com> (raw)
In-Reply-To: <1443546444-5724-1-git-send-email-arjunkrishnababu96@gmail.com>
On Tue, Sep 29, 2015 at 10:37:24PM +0530, Arjun Krishna Babu wrote:
> Two lines of code that were over 80 characters long is fixed by
> splitting them into multiple lines.
>
> This way, the lines of code are now easier to read.
>
> Issue found by checkpatch.
>
> Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com>
> ---
> drivers/staging/vt6655/baseband.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 9e61f2d..3639f9d 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -2089,9 +2089,18 @@ bool BBbVT3253Init(struct vnt_private *priv)
> byVT3253B0_UW2451[ii][0],
> byVT3253B0_UW2451[ii][1]);
>
> - /* Init ANT B select,TX Config CR09 = 0x61->0x45, 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
> + /* Init ANT B select,
> + * TX Config CR09 = 0x61->0x45,
> + * 0x45->0x41(VC1/VC2 define, make the ANT_A, ANT_B inverted)
> + */
> +
> /*bResult &= BBbWriteEmbedded(dwIoBase,0x09,0x41);*/
> - /* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
> +
> + /* Init ANT B select,
> + * RX Config CR10 = 0x28->0x2A,
> + * 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted)
> + */
> +
Please always run your patches through checkpatch.pl, so that you don't
get an email from the maintainers saying that you need to run your patch
through checkpatch.pl.
thanks,
greg k-h
prev parent reply other threads:[~2015-09-30 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 17:07 [PATCH] staging: vt6655: Fixed two lines over 80 characters Arjun Krishna Babu
2015-09-30 2:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930025702.GA26143@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arjunkrishnababu96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=himani93@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sakshi.april5@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox