From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbbI3FNH (ORCPT ); Wed, 30 Sep 2015 01:13:07 -0400 Received: from mail-wi0-f193.google.com ([209.85.212.193]:36607 "EHLO mail-wi0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbbI3FNF (ORCPT ); Wed, 30 Sep 2015 01:13:05 -0400 Date: Wed, 30 Sep 2015 08:10:04 +0300 From: Alexandru Moise <00moses.alexander00@gmail.com> To: Andrew Morton Cc: mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com, js1304@gmail.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable Message-ID: <20150930051004.GA13409@gmail.com> References: <20150927210425.GA20155@gmail.com> <20150929160727.ef70acf2e44575e9470a4025@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929160727.ef70acf2e44575e9470a4025@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc) > > > > static unsigned long zone_reclaimable_pages(struct zone *zone) > > { > > - int nr; > > + unsigned long nr; > > > > nr = zone_page_state(zone, NR_ACTIVE_FILE) + > > zone_page_state(zone, NR_INACTIVE_FILE); > > OK. > Are you sure? Mel Gorman raised the following issue on patch 1/2: https://lkml.org/lkml/2015/9/29/253 Thanks for the review.