Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable

Andrew Morton
2015-09-30T05:25:48Z

On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@gmail.com> wrote:

> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > >
> > > static unsigned long zone_reclaimable_pages(struct zone *zone)
> > > {
> > > - int nr;
> > > + unsigned long nr;
> > >
> > > nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > > zone_page_state(zone, NR_INACTIVE_FILE);
> >
> > OK.
> >
>
> Are you sure? Mel Gorman raised the following issue on patch 1/2:
>
> https://lkml.org/lkml/2015/9/29/253

__zone_watermark_ok() is very different from zone_reclaimable_pages().