From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, gregkh@linuxfoundation.org,
jgunthorpe@obsidianresearch.com, akpm@linux-foundation.org,
Marcel Selhorst <tpmdd@selhorst.net>
Subject: Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver
Date: Wed, 30 Sep 2015 07:02:52 +0100 [thread overview]
Message-ID: <20150930060251.GA7517@srcf.ucam.org> (raw)
In-Reply-To: <20150930055835.GB3874@intel.com>
On Wed, Sep 30, 2015 at 08:58:35AM +0300, Jarkko Sakkinen wrote:
> Right. I think it would make sense to be conservative and use
> acpi_driver only for MSFT0101 because at least I don't know answer
> to this question. It would be a risk to take these fixes to the stable
> kernels othwerwise.
In that case I'd suggest just adding it to the platform driver struct
and tidying up the init path a little (and having the platform driver
init code request resources rather than hardcoding them). It'll make it
easier to deal with any systems that declare TPMs in other tables such
as Device Tree later on.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2015-09-30 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 17:07 [PATCH 0/2] Fix tpm_tis ACPI issue with TPM 2.0 Jarkko Sakkinen
2015-09-29 17:07 ` [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen
2015-09-29 17:26 ` Jason Gunthorpe
2015-09-30 5:56 ` Jarkko Sakkinen
2015-09-30 6:04 ` Matthew Garrett
2015-09-29 17:30 ` Matthew Garrett
2015-09-30 5:58 ` Jarkko Sakkinen
2015-09-30 6:02 ` Matthew Garrett [this message]
2015-09-29 17:07 ` [PATCH 2/2] tpm, tpm_tis: detect TPM2 FIFO devices based on HID Jarkko Sakkinen
2015-09-29 17:43 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930060251.GA7517@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox