From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbbI3GC7 (ORCPT ); Wed, 30 Sep 2015 02:02:59 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:33333 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbbI3GC4 (ORCPT ); Wed, 30 Sep 2015 02:02:56 -0400 Date: Wed, 30 Sep 2015 07:02:52 +0100 From: Matthew Garrett To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, akpm@linux-foundation.org, Marcel Selhorst Subject: Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Message-ID: <20150930060251.GA7517@srcf.ucam.org> References: <1443546431-14948-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1443546431-14948-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150929173025.GA22503@srcf.ucam.org> <20150930055835.GB3874@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930055835.GB3874@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 08:58:35AM +0300, Jarkko Sakkinen wrote: > Right. I think it would make sense to be conservative and use > acpi_driver only for MSFT0101 because at least I don't know answer > to this question. It would be a risk to take these fixes to the stable > kernels othwerwise. In that case I'd suggest just adding it to the platform driver struct and tidying up the init path a little (and having the platform driver init code request resources rather than hardcoding them). It'll make it easier to deal with any systems that declare TPMs in other tables such as Device Tree later on. -- Matthew Garrett | mjg59@srcf.ucam.org