From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbbI3GFF (ORCPT ); Wed, 30 Sep 2015 02:05:05 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:33355 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbbI3GFB (ORCPT ); Wed, 30 Sep 2015 02:05:01 -0400 Date: Wed, 30 Sep 2015 07:04:55 +0100 From: Matthew Garrett To: Jarkko Sakkinen Cc: Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, Marcel Selhorst Subject: Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Message-ID: <20150930060455.GB7517@srcf.ucam.org> References: <1443546431-14948-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1443546431-14948-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150929172653.GB23056@obsidianresearch.com> <20150930055612.GA3874@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930055612.GA3874@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 08:56:12AM +0300, Jarkko Sakkinen wrote: > I found at least all the IDs listed from drivers/acpi/acpi_pnp.c but you > might be right that they might be (don't know) with pnpbios. The entries in acpi_pnp.c mean "If this device is declared in an ACPI table, create a PNP device". TPMs are kind of at the cutoff where some vendors may have shipped non-ACPI systems with TPMs that were declared via pnpbios, so there's a (small) risk that there are some people using TPMs tied to PNP devices without a corresponding ACPI device. > Maybe a better solution would to have two tables and have only MSFT0101 > in tpm_acpi_tbl in order to make sure that old functionality is not > broken up because we want this also to the stable kernels. I'd agree here. -- Matthew Garrett | mjg59@srcf.ucam.org