From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785AbbI3Je6 (ORCPT ); Wed, 30 Sep 2015 05:34:58 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51689 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbbI3Jez (ORCPT ); Wed, 30 Sep 2015 05:34:55 -0400 Date: Wed, 30 Sep 2015 12:34:33 +0300 From: Dan Carpenter To: Tillmann Heidsieck Cc: Larry Finger , devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Punit Vara , stillcompiling@gmail.com, gregkh@linuxfoundation.org, dogukan.ergun@gmail.com, linux-kernel@vger.kernel.org, Joe Perches , Sudip Mukherjee Subject: Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision Message-ID: <20150930093433.GD7340@mwanda> References: <1443286161-3003-1-git-send-email-punitvara@gmail.com> <5606D9CA.1040502@lwfinger.net> <20150928111828.GA10335@sudip-pc> <56095513.4090108@lwfinger.net> <20150929202458.GA4213@themis.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929202458.GA4213@themis.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > The primary requirement for moving a driver out of staging is that it use > > mac80211. No amount of cosmetic fixing will ever make that change for > > rtl8712u! > > As I am pretty sure someone has done something like this before, is > there a best practice write-up on this? Or a driver that is recommended > for usage as a template? That's a good question. The rtl* drivers are basically a dozen copies of the same code. I think we have had a few escape from staging? regards, dan carpenter