From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932842AbbI3LNd (ORCPT ); Wed, 30 Sep 2015 07:13:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43084 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbbI3LNa (ORCPT ); Wed, 30 Sep 2015 07:13:30 -0400 Date: Wed, 30 Sep 2015 13:13:23 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [PATCH v2 03/12] sched: Create preempt_count invariant Message-ID: <20150930111323.GB2903@worktop.programming.kicks-ass.net> References: <20150930071035.514587432@infradead.org> <20150930072303.844400616@infradead.org> <20150930053208.0604317b@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930053208.0604317b@gandalf.local.home> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 05:32:08AM -0400, Steven Rostedt wrote: > On Wed, 30 Sep 2015 09:10:38 +0200 > Peter Zijlstra wrote: > > -#ifdef CONFIG_PREEMPT_COUNT > > -#define PREEMPT_DISABLED (1 + PREEMPT_ENABLED) > > -#else > > -#define PREEMPT_DISABLED PREEMPT_ENABLED > > -#endif > > +#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) > > Hmm, it looks to me that you removed all users of PREEMPT_DISABLED. > > Did you add another user of it? Dunno, lemme go grep ;-) include/linux/sched.h:#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) kernel/sched/core.c: preempt_count_set(PREEMPT_DISABLED); So there still is one user.