From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755983AbbI3Ls1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 07:48:27 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:44013 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751184AbbI3LsY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 07:48:24 -0400
Date: Wed, 30 Sep 2015 14:48:04 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ronit Halder <ronit.crj@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, daeseok.youn@gmail.com,
        driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()
Message-ID: <20150930114804.GG7340@mwanda>
References: <1443593385-7124-1-git-send-email-ronit.crj@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443593385-7124-1-git-send-email-ronit.crj@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 30, 2015 at 11:39:45AM +0530, Ronit Halder wrote:
> In dgap_parsefile() char pointers are set with kstrdup()
> without checking that some string is allocated to that
> char pointer before.

Why would this happen?  Wouldn't it be better to reject the invalid
config file?

regards,
dan carpenter