From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbbI3QFL (ORCPT ); Wed, 30 Sep 2015 12:05:11 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:49605 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbbI3QFF (ORCPT ); Wed, 30 Sep 2015 12:05:05 -0400 Date: Wed, 30 Sep 2015 11:04:54 -0500 From: Felipe Balbi To: Sudip Mukherjee CC: Felipe Balbi , Haavard Skinnemoen , Hans-Christian Egtvedt , Greg Kroah-Hartman , , , Andrew Morton Subject: Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Message-ID: <20150930160454.GD32625@saruman.tx.rr.com> Reply-To: References: <1442682779-20077-1-git-send-email-sudipm.mukherjee@gmail.com> <1442682779-20077-3-git-send-email-sudipm.mukherjee@gmail.com> <20150920161528.GB1447@saruman.tx.rr.com> <20150921111044.GA21986@sudip-pc> <20150923155248.GB13153@sudip-pc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q0rSlbzrZN6k9QnT" Content-Disposition: inline In-Reply-To: <20150923155248.GB13153@sudip-pc> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Q0rSlbzrZN6k9QnT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 21, 2015 at 04:40:57PM +0530, Sudip Mukherjee wrote: > > On Sun, Sep 20, 2015 at 11:15:28AM -0500, Felipe Balbi wrote: > > > On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote: > > > > While building allmodconfig on avr32 the build failed with the erro= r: > > > > "at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefine= d! > > > >=20 > > > > On checking the code it turned out that if CONFIG_OF is defined the= n it > > > > is using at91_pmc_read() which is using at91_pmc_base. And unless > > > > COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And > > > > COMMON_CLK_AT91 is available with AT91 architecture. > > > > Mention the dependency such that this driver builds with avr32 only= if > > > > OF is not enabled. > > > >=20 > > > > Signed-off-by: Sudip Mukherjee > > > > --- > > > >=20 > > > > Tested build with at91_dt_defconfig and allmodconfig of avr32. Buil= d log > > > > at: > > > > https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845 > > > >=20 > > > > drivers/usb/gadget/udc/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/ud= c/Kconfig > > > > index 9a3a6b0..cdbff54 100644 > > > > --- a/drivers/usb/gadget/udc/Kconfig > > > > +++ b/drivers/usb/gadget/udc/Kconfig > > > > @@ -55,7 +55,7 @@ config USB_LPC32XX > > > > =20 > > > > config USB_ATMEL_USBA > > > > tristate "Atmel USBA" > > > > - depends on AVR32 || ARCH_AT91 > > > > + depends on ((AVR32 && !OF) || ARCH_AT91) > > >=20 > > > any chance you can add || COMPILE_TEST here ? I'd like to make > > > sure this builds on my end too. > > With "depends on ((AVR32 && !OF) || ARCH_AT91 || COMPILE_TEST)" > > normal allmodconfig builiding for x86_64 failed with: > >=20 > > drivers/usb/gadget/udc/atmel_usba_udc.c: In function =E2=80=98usba_star= t=E2=80=99: > > drivers/usb/gadget/udc/atmel_usba_udc.c:1783:25: error: =E2=80=98USBA_E= NABLE_MASK=E2=80=99 undeclared (first use in this function) > > usba_writel(udc, CTRL, USBA_ENABLE_MASK); > > ^ > > drivers/usb/gadget/udc/atmel_usba_udc.c: In function =E2=80=98usba_stop= =E2=80=99: > > drivers/usb/gadget/udc/atmel_usba_udc.c:1800:25: error: =E2=80=98USBA_D= ISABLE_MASK=E2=80=99 undeclared (first use in this function) > > usba_writel(udc, CTRL, USBA_DISABLE_MASK); > > ^ > >=20 > > Looks like USBA_DISABLE_MASK and USBA_ENABLE_MASK is defined under > > #if defined(CONFIG_AVR32). :( > Can i check anything else here? Like I said with COMPILE_TEST > allmodconfig on x86_64 is failing. then keep it as is, but it would be nice to get that sorted out so I can do compile tests on my end too. --=20 balbi --Q0rSlbzrZN6k9QnT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDAgmAAoJEIaOsuA1yqRE3H4P/ixoJymqcBXFt1qLf/U4Pq76 NPQtoQo5kSUW9nfALXFLuY4cK3kLfokro6bwQhiP4k9eYe2xxsdSxpq1Nog5Ywe1 fGOqGJOyZ/x/lEFp1wBAr1JbngtVNOgs3GpamK3Vto5r4JjJAjSBNdTl48Oanpa4 p7fToYvkOXHY3wMvx533/jsT6W+ydbl0VreXTnui9525/d/5sp+lS+kMF6RfcEfj 5DpgAM3VlITKgjl6jqShHyNAa6SR/f09A0N55nKi7Ty36NxkazS/2uzMxCOR70cF qvkvp1xR1Vtfoqf7aVB7y2ut/pJm/qBzRj1+2XSln7bsE6SBReG0kWNnb5wldsmG 4MKd1zhtvQ36ej+cBXihWOyY35GXQcRn0Jpm/soSei/yjL03Wtsm0Ip4czR5l3CZ 5MbNBIoOr52LmPaeEYWGz1j/NoYsT+QjB1CCq6PCeh0JRrGen3e4Rm6eAmgEz1CU Urr9sq2mL/Uk+boE+TQ/jr4eSu02zIg/FB/1S1cuWwXPhABpp8CafvcZZHPjuD0V MVsamR7meBvvPRZyY+eKBM4fReKBeLr+Cs/unyQgBRvQz3cIWr2P/TirszHG7XYU iy9w2HuffnrxGdziSqs/9NcfSgRAU1ckzkhRHXtuWDeZhm709Vk42akyrGAjmlBj yZOWwlzNM61zsL8xl9lN =p5mN -----END PGP SIGNATURE----- --Q0rSlbzrZN6k9QnT--